Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate CSRDuration to GA #32405

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 22, 2022

Previous PR #28070 didn't change the feature gate.
With kubernetes/kubernetes#108782 in now, and kubernetes/enhancements#3250 merged, we should update the feature gate docs.

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 22, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2022
@netlify
Copy link

netlify bot commented Mar 22, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: dfb03f2

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/623955ab800817000868d630

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 22, 2022
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 112c6b93dc94b7ea9a51a3dcc3100b7c85e4c53c

@mehabhalodiya
Copy link
Contributor

enhancement issue: kubernetes/enhancements#2784

@mehabhalodiya
Copy link
Contributor

/assign @chrisnegus

@enj
Copy link
Member

enj commented Mar 22, 2022

/lgtm

@mehabhalodiya
Copy link
Contributor

/cc @nate-double-u

@nate-double-u
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nate-double-u

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit f6a43e1 into kubernetes:dev-1.24 Mar 23, 2022
@tengqm tengqm deleted the csrduation-ga branch March 23, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants