Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ko : Updated KubeCon dates #31482

Merged
merged 1 commit into from
Jan 25, 2022
Merged

ko : Updated KubeCon dates #31482

merged 1 commit into from
Jan 25, 2022

Conversation

krvaibhaw
Copy link
Contributor

Updated the _index.html file content/ko/_index.html to include the
latest links for the Cloud Native Computing Foundation’s flagship conference.
KubeCon + CloudNativeCon

KubeCon North America on October 24-28, 2022

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2022
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 24, 2022
@krvaibhaw
Copy link
Contributor Author

/assign @jihoon-seo

@netlify
Copy link

netlify bot commented Jan 24, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: ecef64a

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61ee7548711f380008abfe63

😎 Browse the preview: https://deploy-preview-31482--kubernetes-io-main-staging.netlify.app

jihoon-seo
jihoon-seo reviewed Jan 24, 2022
View reviewed changes
Copy link
Member

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krvaibhaw Thank you for proposing changes!

To sync with EN version (KubeCon EU first, and then KubeCon NA):

content/ko/_index.html Outdated Show resolved Hide resolved
@krvaibhaw krvaibhaw requested a review from jihoon-seo January 24, 2022 09:46
@jihoon-seo
Copy link
Member

@krvaibhaw Thank you!

For anyone's information:
In EN version, there exists a small nit:

  • As-is: &utm_campaign=kccncna21
  • To-be: &utm_campaign=kccncna22

And @krvaibhaw you proactively fixed that error in this PR! Great job! 😊
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d23a81fa72ce550fb5c357c5e153ffd2ae964cab

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jihoon-seo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5c5e87e into kubernetes:main Jan 25, 2022
@krvaibhaw krvaibhaw mentioned this pull request Jan 25, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gochist gochist Awaiting requested review from gochist

@yoonian yoonian Awaiting requested review from yoonian

@jihoon-seo jihoon-seo Awaiting requested review from jihoon-seo

Assignees

@jihoon-seo jihoon-seo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krvaibhaw @jihoon-seo @k8s-ci-robot