Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: meet our contributors APAC India region #31208

Merged
merged 1 commit into from
Jan 7, 2022
Merged

blog: meet our contributors APAC India region #31208

merged 1 commit into from
Jan 7, 2022

Conversation

Priyankasaggu11929
Copy link
Member

This PR adds the first blog post for India region, in the series of "Meet Our Contributors - APAC" blog series.

Reference issue: kubernetes/community#4469 (comment)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Jan 5, 2022
@k8s-ci-robot k8s-ci-robot requested review from onlydole and sftim January 5, 2022 08:22
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 5, 2022
Debanitrkl
Debanitrkl reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@Debanitrkl Debanitrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉🎉

@netlify
Copy link

netlify bot commented Jan 5, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 4bb3f36

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61d8539116c8b10007122462

😎 Browse the preview: https://deploy-preview-31208--kubernetes-io-main-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Jan 5, 2022 •
edited
Loading

Hi folks

I wonder if you'd consider publishing this to https://k8s.dev/blog/ first @Priyankasaggu11929 ?
If so, please open a PR against https://github.com/kubernetes/contributor-site (the technology used there is very similar, you can probably copy the file over verbatim) and mention its URL in a comment on this PR.

@Priyankasaggu11929
Copy link
Member Author

Hello @sftim, Happy New Year :)

And thanks for pointing. I've raised the asked PR: kubernetes/contributor-site#279

@sftim
Copy link
Contributor

sftim commented Jan 5, 2022

/hold
for kubernetes/contributor-site#279

(and then we should synchronize the copy, publication date, etc)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2022
@Priyankasaggu11929
Copy link
Member Author

@sftim, I've synchronized this PR with the reviewed content & publication date (Jan 10, 2022) from the kubernetes/contributor-site#279

Kindly please review. Thank you!

sftim
sftim reviewed Jan 7, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny remaining changes

content/en/blog/_posts/2022-01-10-meet-our-contributors-APAC-India-region-01.md Outdated
Comment on lines 2 to 5
layout: blog
title: "Meet Our Contributors - APAC (India region)"
date: 2022-01-10
slug: meet-our-contributors-india-ep-01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
layout: blog
title: "Meet Our Contributors - APAC (India region)"
date: 2022-01-10
slug: meet-our-contributors-india-ep-01
layout: blog
title: "Meet Our Contributors - APAC (India region)"
date: 2022-01-10T12:00:00+0000
slug: meet-our-contributors-india-ep-01
canonicalUrl: https://kubernetes.dev/blog/2022/01/10/meet-our-contributors-india-ep-01/

(delay until the other post is published, and mark that one as the canonical URL)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim, looks like the other post is live on the site now. I've updated the PR with the changes pointed above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, that's a bug!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I was wondering the same. 😅 The date for publish is Jan 10.

@sftim
Copy link
Contributor

sftim commented Jan 7, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2022
@sftim
Copy link
Contributor

sftim commented Jan 7, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 501289139165745a938b53d03ffcec42488423e1

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 68a90ae into kubernetes:main Jan 7, 2022
@Sea-n Sea-n mentioned this pull request Jul 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Debanitrkl Debanitrkl Debanitrkl left review comments

@sftim sftim sftim left review comments

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Priyankasaggu11929 @sftim @k8s-ci-robot @Debanitrkl