Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document PodAndContainerStatsFromCRI feature #30535

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Document PodAndContainerStatsFromCRI feature #30535

merged 1 commit into from
Nov 23, 2021

Conversation

haircommander
Copy link
Contributor

There will be docs... one day
issue: kubernetes/enhancements#2371

@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Nov 17, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 17, 2021
@netlify
Copy link

netlify bot commented Nov 17, 2021 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 7c1e61a

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/619d1b81afe50e00081a0ac2

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 17, 2021
@haircommander haircommander mentioned this pull request Nov 17, 2021
Open
17 tasks
@jlbutler
Copy link
Contributor

/assign

@jlbutler
Copy link
Contributor

@haircommander Reminder that tomorrow Nov 23rd is the deadline for 1.23 Docs Ready for Review. Please push your docs content for this enhancement and remove the work-in-progress label when ready for review.

We have a tight turnaround to getting docs reviewed and approved for the release, and we're hoping to have all docs in for review by EOB tomorrow. Thank you!

@haircommander haircommander changed the title [WIP] Document PodAndContainerStatsFromCRI feature Document PodAndContainerStatsFromCRI feature Nov 22, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 22, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 22, 2021
@haircommander
Copy link
Contributor Author

sorry for the noise, forgot which branch this was targeted at

@bobbypage
Copy link
Member

LGTM for docs, I also suggest we add note of which container runtimes (i.e. containerd, CRI-O) support the new endpoints. For containerd, this will be containerd 1.6+

@haircommander
Copy link
Contributor Author

LGTM for docs, I also suggest we add note of which container runtimes (i.e. containerd, CRI-O) support the new endpoints. For containerd, this will be containerd 1.6+

Added!

@jlbutler
Copy link
Contributor

I see a few terms we typical capitalize/stylize, but I think in context this works. Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ad3851fde4ebe7cba811f067b72152665dd6b610

@jlbutler
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlbutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 007e2ea into kubernetes:dev-1.23 Nov 23, 2021
@mengjiao-liu mengjiao-liu mentioned this pull request Dec 22, 2021
Closed
@sftim sftim mentioned this pull request Nov 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jlbutler jlbutler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@haircommander @jlbutler @bobbypage @k8s-ci-robot