Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI migration portworx in alpha state #30445

Merged
merged 1 commit into from
Nov 29, 2021
Merged

CSI migration portworx in alpha state #30445

merged 1 commit into from
Nov 29, 2021

Conversation

trierra
Copy link
Contributor

@trierra trierra commented Nov 11, 2021 •
edited
Loading

No description provided.

@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Nov 11, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 11, 2021
@netlify
Copy link

netlify bot commented Nov 11, 2021 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 02f63b9

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61a5212ccc40190008360434

@k8s-ci-robot
Copy link
Contributor

Welcome @trierra!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Nov 11, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 11, 2021
@trierra trierra mentioned this pull request Nov 11, 2021
Open
12 tasks
@jlbutler
Copy link
Contributor

/assign @ramrodo

RinkiyaKeDad
RinkiyaKeDad reviewed Nov 15, 2021
View reviewed changes
Copy link
Member

@RinkiyaKeDad RinkiyaKeDad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, left some suggestions! 🙂

content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
@trierra trierra force-pushed the csi-portworx branch 2 times, most recently from 670f854 to c86d0ae Compare November 16, 2021 01:24
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2021
@jlbutler
Copy link
Contributor

@trierra approved pending resolution of last nits. not required, but seem like ok quick changes.

@trierra
Copy link
Contributor Author

trierra commented Nov 23, 2021 via email

@jihoon-seo
Copy link
Member

/remove-language de
/remove-language es
/remove-language fr
/remove-language id
/remove-language ja
/remove-language ko
/remove-language pl
/remove-language pt
/remove-language ru
/remove-language zh
/remove-area blog
/remove-area release-eng
/remove-sig release

@k8s-ci-robot k8s-ci-robot removed language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 29, 2021
@jlbutler
Copy link
Contributor

jlbutler commented Nov 29, 2021 •
edited
Loading

I can make this change only on Friday nov 26 if it’s ok Best regards, Oksana Naumov

Hi @trierra tomorrow is the Docs Ready deadline for 1.23. Could you revisit these last couple of nits? We can get a final review and get this merged. Thanks!

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 29, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@trierra trierra force-pushed the csi-portworx branch 2 times, most recently from ecfa864 to 8819629 Compare November 29, 2021 18:43
@trierra
Copy link
Contributor Author

trierra commented Nov 29, 2021

@jlbutler done!

@jlbutler
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlbutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3480451 into kubernetes:dev-1.23 Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RinkiyaKeDad RinkiyaKeDad RinkiyaKeDad left review comments

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@thockin thockin Awaiting requested review from thockin

Assignees

@ramrodo ramrodo

@jlbutler jlbutler

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23
Development

Successfully merging this pull request may close these issues.
7 participants
@trierra @k8s-ci-robot @jlbutler @ramrodo @msau42 @jihoon-seo @RinkiyaKeDad