Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Document the environment variable substitution feature of kustomize configMapGenerator #30348

Merged
merged 1 commit into from
Jan 5, 2022
Merged

[DOCS] Document the environment variable substitution feature of kustomize configMapGenerator #30348

merged 1 commit into from
Jan 5, 2022

Conversation

afirth
Copy link
Member

@afirth afirth commented Nov 3, 2021 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 3, 2021
@netlify
Copy link

netlify bot commented Nov 3, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: b9da040

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61d2d6be44d5c1000892ee54

😎 Browse the preview: https://deploy-preview-30348--kubernetes-io-main-staging.netlify.app

@jimangel
Copy link
Member

jimangel commented Dec 6, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 26072c53754c8ff39c0ba13c58546cbf43d569aa

@afirth
Copy link
Member Author

afirth commented Dec 8, 2021

thanks @jimangel! According to the bot, you are also the chosen approver?
/assign @jimangel

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2021
@afirth afirth force-pushed the 2021-11-03-docs-for-kustomize-env-vars branch from 43aa3f2 to b9da040 Compare January 3, 2022 10:58
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 3, 2022
@afirth
Copy link
Member Author

afirth commented Jan 3, 2022 •
edited
Loading

@jimangel rebased and awaiting fresh lgtm + approve

onlydole
onlydole approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@onlydole onlydole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @afirth! This looks good to me.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: onlydole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022
@afirth
Copy link
Member Author

afirth commented Jan 5, 2022

Thanks @onlydole @jimangel , just need another /lgtm as the rebase revoked it

@annajung
Copy link
Contributor

annajung commented Jan 5, 2022

https://deploy-preview-30348--kubernetes-io-main-staging.netlify.app/docs/tasks/manage-kubernetes-objects/kustomization/

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2de46756705184bffc3803c3e3585fd865e90559

@k8s-ci-robot k8s-ci-robot merged commit 988b1ba into kubernetes:main Jan 5, 2022
@afirth afirth mentioned this pull request Jan 6, 2022
Closed
@jacekszlachtass jacekszlachtass mentioned this pull request Jan 29, 2022
Closed
This was referenced Jul 28, 2022
Merged
Merged
Closed
@sftim
Copy link
Contributor

sftim commented Jul 29, 2022

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Jul 29, 2022
@KnVerey KnVerey mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlydole onlydole onlydole approved these changes

@tengqm tengqm Awaiting requested review from tengqm

@geoffcline geoffcline Awaiting requested review from geoffcline

@RinkiyaKeDad RinkiyaKeDad Awaiting requested review from RinkiyaKeDad

Assignees

@jimangel jimangel

@annajung annajung

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: support for environment variables
8 participants
@afirth @jimangel @k8s-ci-robot @annajung @sftim @onlydole @geoffcline @RinkiyaKeDad