Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Add content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md #30183

Closed

Conversation

arsheelsheikh
Copy link

localization
[hi] Add content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mittalyashu after the PR has been reviewed.
You can assign the PR to them by writing /assign @mittalyashu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 21, 2021
Copy link
Contributor

@AvineshTripathi AvineshTripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think abbreviation should remain as it is while localising also on a overview I found these changes to be appropriate

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch out for relying on automation to help with translation.

@arsheelsheikh arsheelsheikh requested a review from sftim November 10, 2021 00:59
@sftim
Copy link
Contributor

sftim commented Nov 17, 2021

@arsheelsheikh would you be willing to squash this down to 1 commit (https://kubernetes.io/docs/contribute/new-content/open-a-pr/#addressing-feedback-locally has some details, and it's OK to ask more questions too)

Update content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md

Co-authored-by: Avinesh Tripathi  <[email protected]>

Update content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md

Co-authored-by: Avinesh Tripathi  <[email protected]>

Update content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md

Co-authored-by: Tim Bannister <[email protected]>

Updated user-guide-windows-containers.md

corrections

Update content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md

Co-authored-by: Tim Bannister <[email protected]>

Update content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md

Co-authored-by: Tim Bannister <[email protected]>

localized a comment
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 26, 2021

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: arsheelsheikh / name: Arsheel Sheikh (1602913)

@arsheelsheikh
Copy link
Author

arsheelsheikh commented Nov 26, 2021

@arsheelsheikh would you be willing to squash this down to 1 commit (https://kubernetes.io/docs/contribute/new-content/open-a-pr/#addressing-feedback-locally has some details, and it's OK to ask more questions too)

@sftim I followed the handbook and tried squashing but it seems something is wrong!

@sftim
Copy link
Contributor

sftim commented Nov 28, 2021

This change looks reasonable, commit wise. The commit message summary “hi localization” isn't as helpful as it could be.

If you can, check out the branch you've named arsheelsheikh and run git commit --amend. Now you can write a new commit message that more clearly summarises the change. For example:

Localize “Guide for scheduling Windows containers in Kubernetes” into Hindi

Copy link
Member

@jayesh-srivastava jayesh-srivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I noticed that this document contains a mixture of both windows and विंडोज. I guess we should stick to one only. Can you please take a look at other Hindi docs and make the change accordingly?

@anubha-v-ardhan
Copy link
Member

Hey, I noticed that this document contains a mixture of both windows and विंडोज. I guess we should stick to one only. Can you please take a look at other Hindi docs and make the change accordingly?

We're writing it as Windows, it being a trademark of Microsoft Corporation.

@jayesh-srivastava
Copy link
Member

Hey, I noticed that this document contains a mixture of both windows and विंडोज. I guess we should stick to one only. Can you please take a look at other Hindi docs and make the change accordingly?

We're writing it as Windows, it being a trademark of Microsoft Corporation.

That should be it then. @arsheelsheikh can you please do the needful.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 8, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 8, 2022
@anubha-v-ardhan
Copy link
Member

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 8, 2022
@arsheelsheikh
Copy link
Author

All these PR mails were sent to the spam folder due to which I missed track on this PR, just checked now

@arsheelsheikh
Copy link
Author

should I be making fresh PR now?

@sftim
Copy link
Contributor

sftim commented May 9, 2022

You can update this PR @arsheelsheikh; you don't need to make a new one.

@Sea-n
Copy link
Member

Sea-n commented Jun 2, 2022

Hey @arsheelsheikh, of course you can (and you should) update this PR instead of open a new one.

But before we move on, you have to sign CLA so that the check can be pass.
/easycla

Edit: The check passed after manually refresh.

@divya-mohan0209
Copy link
Contributor

Hey @arsheelsheikh , you can make changes on this PR itself OR open a fresh PR whichever is comfortable for you. Could you please do it at the earliest possible since this has been pending for ~ 1 month now?

@Sea-n
Copy link
Member

Sea-n commented Jul 22, 2022

Hey @arsheelsheikh,

Thanks for purposing this PR. But since you didn't respond for a while, we have to close this PR now.
/close

Feel free to open a fresh one (and don't forget to mention this PR) when you are ready to move forward.

@k8s-ci-robot
Copy link
Contributor

@Sea-n: Closed this PR.

In response to this:

Hey @sean,

Thanks for purposing this PR. But since you didn't respond for a while, we have to close this PR now.
/close

Feel free to open a fresh one (and don't forget to mention this PR) when you are ready to move forward.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants