-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hi] Add content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md #30183
[hi] Add content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md #30183
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think abbreviation should remain as it is while localising also on a overview I found these changes to be appropriate
content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md
Outdated
Show resolved
Hide resolved
content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md
Outdated
Show resolved
Hide resolved
content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md
Outdated
Show resolved
Hide resolved
content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Watch out for relying on automation to help with translation.
content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md
Outdated
Show resolved
Hide resolved
content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md
Outdated
Show resolved
Hide resolved
content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md
Outdated
Show resolved
Hide resolved
content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md
Outdated
Show resolved
Hide resolved
@arsheelsheikh would you be willing to squash this down to 1 commit (https://kubernetes.io/docs/contribute/new-content/open-a-pr/#addressing-feedback-locally has some details, and it's OK to ask more questions too) |
Update content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md Co-authored-by: Avinesh Tripathi <[email protected]> Update content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md Co-authored-by: Avinesh Tripathi <[email protected]> Update content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md Co-authored-by: Tim Bannister <[email protected]> Updated user-guide-windows-containers.md corrections Update content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md Co-authored-by: Tim Bannister <[email protected]> Update content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md Co-authored-by: Tim Bannister <[email protected]> localized a comment
242a42a
to
1602913
Compare
|
@sftim I followed the handbook and tried squashing but it seems something is wrong! |
This change looks reasonable, commit wise. The commit message summary “hi localization” isn't as helpful as it could be. If you can, check out the branch you've named arsheelsheikh and run
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I noticed that this document contains a mixture of both windows
and विंडोज
. I guess we should stick to one only. Can you please take a look at other Hindi docs and make the change accordingly?
We're writing it as Windows, it being a trademark of Microsoft Corporation. |
That should be it then. @arsheelsheikh can you please do the needful. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
All these PR mails were sent to the spam folder due to which I missed track on this PR, just checked now |
should I be making fresh PR now? |
You can update this PR @arsheelsheikh; you don't need to make a new one. |
Hey @arsheelsheikh, of course you can (and you should) update this PR instead of open a new one.
Edit: The check passed after manually refresh. |
Hey @arsheelsheikh , you can make changes on this PR itself OR open a fresh PR whichever is comfortable for you. Could you please do it at the earliest possible since this has been pending for ~ 1 month now? |
Hey @arsheelsheikh, Thanks for purposing this PR. But since you didn't respond for a while, we have to close this PR now. Feel free to open a fresh one (and don't forget to mention this PR) when you are ready to move forward. |
@Sea-n: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
localization
[hi] Add content/hi/docs/setup/production-environment/windows/user-guide-windows-containers.md