-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move kubectl overview to be section index #29847
Move kubectl overview to be section index #29847
Conversation
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: 77a598c 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62209391ca15f200086a5a23 😎 Browse the preview: https://deploy-preview-29847--kubernetes-io-main-staging.netlify.app |
An enabling change for #25943 |
168b095
to
dafeaa1
Compare
@@ -4,16 +4,19 @@ id: kubectl | |||
date: 2018-04-12 | |||
full_link: /docs/user-guide/kubectl-overview/ | |||
short_description: > | |||
A command line tool for communicating with a Kubernetes API server. | |||
A command line tool for communicating with a Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A command line tool for communicating with a Kubernetes cluster API server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for me both is right depending on the target group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the tooltip text, shown when you hover. You can always click on the tooltip to learn more. I think this text is right for a tooltip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling out, "Kubernetes API server" seems more specific than "cluster". Is it more important to identify the Kubernetes API server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's why I prefer “cluster”: if we say “API server” in the tooltip, I'm worried that some newcomers will feel that they need to learn what a Kubernetes API server is—not an easy thing to grasp—and that some proportion of those will just write off Kubernetes as too hard to learn.
The full description is welcome to make the details clear.
## {{% heading "whatsnext" %}} | ||
|
||
* Read the `kubectl` [command reference](/docs/reference/kubectl/kubectl/). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Find some further useful command examples on the kubectl
cheat sheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe useful to add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually prefer to keep migration PRs separate from PRs that add new content.
@mkorbi have I convinced you that we can accept these changes as-is? Happy to discuss further. |
dafeaa1
to
9690fda
Compare
cc29133
to
fee70f0
Compare
/lgtm I wonder if this should land after the release and if we need to boost visibility to localization (to me it feels like a small big change vs. a refactor)? |
LGTM label has been added. Git tree hash: 7c71f4302318adc08eff1480816accd0c088dbee
|
Happy to let this land after the v1.23 release and yes, we should consider applying the refactor label. |
fee70f0
to
a6ebe69
Compare
@jimangel the only changes since your previous LGTM were a (quite big) rebase with no manual rework |
## {{% heading "whatsnext" %}} | ||
|
||
* Read the `kubectl` [command reference](/docs/reference/kubectl/kubectl/). | ||
* Read the `kubectl` [command line arguments](/docs/reference/kubectl/kubectl/) reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @sftim, Can you check the links for the first two items (links are the same)?
The page could be configured to ignore the list of section links at the bottom of the page, or do you think the links add value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed?
@@ -1,5 +1,551 @@ | |||
--- | |||
title: "kubectl" | |||
title: Command line tool (kubectl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Should the title contain Kubernetes?
Kubernetes command-line tool (kubectl)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kbhawkey let's save that for a different PR; that would be a change beyond the page move that this PR's title covers.
Also: - use glossary definition in page introduction - tidy broken link in What's Next section - update links to refer to moved page
Also, reorder the section overall.
f8c79a0
to
77a598c
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbhawkey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: f2f96258cb8f54c401590ed95201140accd6faa3
|
Also:
/sig cli
/language en
/kind cleanup