-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Alignment Issue of Cards In Community Page #29644
Conversation
Welcome @CIPHERTron! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: a04e248 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61390874eb70a70008e3e0d7 😎 Browse the preview: https://deploy-preview-29644--kubernetes-io-main-staging.netlify.app |
/area web-development |
@CIPHERTron I had a chance to review this, and it looks good to me! Note for @sftim I'm in the process of trying to get REVIEWER status in #contribex-mentoring. Is there something I need to do officially to get this review to count towards my review count? The changes proposed in the PR seem solid to me, and pass checks. :) Is there anything else needed from me to help @CIPHERTron get this merged? Thanks for any help you can provide! |
@CIPHERTron, looks okay to me. Just to clarify, your remark, "refactor in the community website in terms of CSS" is an observation to address in a future PR? |
Yes @chrismetz09, I plan to address it in a future PR. I've opened an issue regarding the same here. |
Heyy @chrismetz09 can we wrap up this PR? Thanks! |
👀 |
@chrismetz09 can you please |
@CIPHERTron I found this change hard to review because there are lots of changes here. It looks like you've combined a refactoring / tidying change with an actual fix? (I'm not sure). If you can talk reviewers through what you've changed and why, that will help us get this reviewed and merged. |
Hi @CIPHERTron . Thanks for contributing. |
@CIPHERTron: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@CIPHERTron thanks for the PR! I think it would be best to separate your changes into individual PRs (at the very least different commits) for ease of review. Given the age of the PR without action, I'm going to close, but feel free to reopen when ready to address feedback / conflicts. Thanks! /close |
@jimangel: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubernetes.io/community
and introduces the following behavior:k8s.mp4
Make each card of the same size
Minor refactor - Removed unnecessary CSS
However, there's still a lot to refactor in the community website in terms of CSS. For instance:
Closes #29155