Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.22] kubectl command headers docs #28692

Merged
merged 1 commit into from
Jul 27, 2021
Merged

[1.22] kubectl command headers docs #28692

merged 1 commit into from
Jul 27, 2021

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jun 29, 2021 •
edited
Loading

  • This 1.22 docs PR adds a section on kubectl environment variables.
  • Adds instructions for how to turn of kubectl HTTP command headers using the KUBECTL_COMMAND_HEADERS environment variable.

k/e

k/k

@k8s-ci-robot k8s-ci-robot added this to the 1.22 milestone Jun 29, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 29, 2021
@netlify
Copy link

netlify bot commented Jun 29, 2021 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 8a6badc

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60f9be720acae30007c5ff33

@seans3
Copy link
Contributor Author

seans3 commented Jun 29, 2021

/sig cli

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Jun 29, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 29, 2021
@seans3 seans3 changed the title [WIP] [1.22] kubectl headers docs [WIP] [1.22] kubectl command headers docs Jun 29, 2021
@seans3 seans3 marked this pull request as draft June 30, 2021 00:08
@seans3
Copy link
Contributor Author

seans3 commented Jun 30, 2021

/assign @carlisia

@seans3
Copy link
Contributor Author

seans3 commented Jun 30, 2021

/assign @sftim

@seans3
Copy link
Contributor Author

seans3 commented Jun 30, 2021

Link to kubectl-plugins docs: https://kubernetes.io/docs/tasks/extend-kubectl/kubectl-plugins/

@sftim
Copy link
Contributor

sftim commented Jun 30, 2021

Hi @seans3

What help did you want with this PR?

@seans3
Copy link
Contributor Author

seans3 commented Jun 30, 2021 •
edited
Loading

Hi Sean Sullivan

What help did you want with this PR?

None yet. Just wanted to let you know we will address the issue you raised about documenting this feature for kubectl-plugins. So I wanted to point out this placeholder PR for you to keep you in the loop.

@PI-Victor
Copy link
Member

Hello @seans3 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 20th of July, 11:59 PM PDT. Thank you!

@seans3 seans3 force-pushed the kubectl-headers-docs-1.22 branch from a217551 to b193eca Compare July 21, 2021 00:18
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2021
@seans3 seans3 force-pushed the kubectl-headers-docs-1.22 branch from b193eca to f094afb Compare July 21, 2021 00:19
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2021
@seans3 seans3 changed the title [WIP] [1.22] kubectl command headers docs [1.22] kubectl command headers docs Jul 21, 2021
@seans3 seans3 marked this pull request as ready for review July 21, 2021 00:20
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2021
@seans3 seans3 force-pushed the kubectl-headers-docs-1.22 branch from f094afb to bc23185 Compare July 21, 2021 00:44
@seans3
Copy link
Contributor Author

seans3 commented Jul 21, 2021

/assign @PI-Victor

@seans3
Copy link
Contributor Author

seans3 commented Jul 21, 2021

/assign @PI-Victor

sftim
sftim reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this page generated from code? If so, was this update made using the existing generator?

sftim
sftim reviewed Jul 22, 2021
View reviewed changes
data/i18n/en/en.toml Outdated Show resolved Hide resolved
@seans3 seans3 force-pushed the kubectl-headers-docs-1.22 branch 2 times, most recently from d2c2a3c to 6c2d4be Compare July 22, 2021 18:45
@seans3
Copy link
Contributor Author

seans3 commented Jul 22, 2021 •
edited
Loading

Is this page generated from code? If so, was this update made using the existing generator?

I did not generate the HTML. I just copied the table format from the Options section directly above. Please let me know if this works.

@seans3 seans3 force-pushed the kubectl-headers-docs-1.22 branch from 6c2d4be to 8a6badc Compare July 22, 2021 18:52
@sftim
Copy link
Contributor

sftim commented Jul 26, 2021

This looks OK to me.
@kubernetes/sig-cli-pr-reviews is this change technically correct? If so, please LGTM.

@PI-Victor
Copy link
Member

ping @kubernetes/sig-cli-pr-reviews please give this a lgtm so we can have it merge today, the deadline is here, thank you!

soltysh
soltysh approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 35e3d9eadc89d6a3dd1e6ae13199f5d68914f33e

@PI-Victor
Copy link
Member

appreciate it, thanks!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PI-Victor, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 87ae40d into kubernetes:dev-1.22 Jul 27, 2021
@fenggw-fnst fenggw-fnst mentioned this pull request Nov 23, 2021
Merged
@alexzielenski alexzielenski mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@PI-Victor PI-Victor PI-Victor left review comments

@soltysh soltysh soltysh approved these changes

@bradtopol bradtopol Awaiting requested review from bradtopol

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@carlisia carlisia

@soltysh soltysh

@PI-Victor PI-Victor

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
6 participants
@seans3 @sftim @PI-Victor @k8s-ci-robot @soltysh @carlisia