Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update feature gates for 1.22 #28644

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Update feature gates for 1.22 #28644

merged 1 commit into from
Jul 5, 2021

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jun 27, 2021 •
edited
Loading

This PR updates the feature gate status based on upstream
implementation.

The chanegs are listed below with links to upstream PRs merged:

@k8s-ci-robot k8s-ci-robot added this to the 1.22 milestone Jun 27, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2021
@netlify
Copy link

netlify bot commented Jun 27, 2021 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 372d34d

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60dee872c982750007cf564a

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2021
@sftim
Copy link
Contributor

sftim commented Jun 27, 2021

@PI-Victor FYI

sftim
sftim reviewed Jun 27, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a few corrections

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
| `CSINodeInfo` | `false` | Alpha | 1.12 | 1.13 |
| `CSINodeInfo` | `true` | Beta | 1.14 | 1.16 |
| `CSINodeInfo` | `true` | GA | 1.17 | |
| `CSIPersistentVolume` | `false` | Alpha | 1.9 | 1.9 |
| `CSIPersistentVolume` | `true` | Beta | 1.10 | 1.12 |
| `CSIPersistentVolume` | `true` | GA | 1.13 | - |
| `CSIServiceAccountToken` | `false` | Alpha | 1.20 | 1.20 |
| `CSIServiceAccountToken` | `true` | Beta | 1.21 | 1.21 |
| `CSIServiceAccountToken` | `true` | GA| 1.22 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mini-nit:

Suggested change
| `CSIServiceAccountToken` | `true` | GA| 1.22 | |
| `CSIServiceAccountToken` | `true` | GA | 1.22 | |

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2021
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/es Issues or PRs related to Spanish language language/id Issues or PRs related to Indonesian language size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 28, 2021
@sftim
Copy link
Contributor

sftim commented Jun 28, 2021

/remove-area blog
/remove-language/es
/remove-language/id
/remove-language/it
/remove-language/ja
/remove-language/pl
/remove-language/pt
/remove-language/ru
/remove-language/zh

@PI-Victor
Copy link
Member

can we get this merged so it's no longer needed to constantly rebase?
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 414598ed3c0590207841e5fb76a0c70e99e30301

@chendave chendave mentioned this pull request Jun 30, 2021
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2021
@tengqm
Copy link
Contributor Author

tengqm commented Jun 30, 2021

Some more changes coming in ... The MemoryManager one was not documented since 1.21.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 30, 2021
@tengqm
Copy link
Contributor Author

tengqm commented Jun 30, 2021

Alright, here is another one:

APIServerTracing kubernetes/kubernetes#94942

@sftim
Copy link
Contributor

sftim commented Jun 30, 2021

They just keep on coming!

@chendave chendave mentioned this pull request Jul 2, 2021
Closed
@tengqm
Update feature gates for 1.22
372d34d 
This PR updates the feature gate status based on upstream
implementation.

The chanegs are listed below with links to upstream PRs merged:

- BalanceAttacedNodeVolumes  kubernetes/kubernetes#102443
- CSIMigrationvSphereComplete kubernetes/kubernetes#101272
- CSIServiceAccountToken kubernetes/kubernetes#103001
- DaemonSetUpdateSurge kubernetes/kubernetes#101742
- DisableCloudProviders kubernetes/kubernetes#100136
- IndexedJob kubernetes/kubernetes#101292
- LegacyNodeRoleBehavior    kubernetes/kubernetes#100776
- NamespaceDefaultLabelName kubernetes/kubernetes#101342
- NetworkPolicyEndPort   kubernetes/kubernetes#102834
- NodeDisruptionExclusion   kubernetes/kubernetes#100776
- PodAffinityNamespaceSelector  kubernetes/kubernetes#101496
- PodDeletionCost  kubernetes/kubernetes#101080
- PreferNominatedNode kubernetes/kubernetes#102201
- ServiceLoadBalancerClass  kubernetes/kubernetes#103129
- ServiceNodeExclusion  kubernetes/kubernetes#100776
- ServiceTopology kubernetes/kubernetes#102412
- SizeMemoryBackedVoluems kubernetes/kubernetes#101048
- StatefulSetMinReadySeconds kubernetes/kubernetes#100842
- SuspendJob kubernetes/kubernetes#102022
- WindowsHostProcessContainers  kubernetes/kubernetes#99576
@tengqm
Copy link
Contributor Author

tengqm commented Jul 2, 2021

Got a new one:

@sftim
Copy link
Contributor

sftim commented Jul 2, 2021

💭 if there was a single document listing all known feature gates for Kubernetes - doesn't have to list anything else, just the names would do - then the code integration checks could error out if any component supports an unrecognized gate name.

(maybe something like that already happens?)

@tengqm
Copy link
Contributor Author

tengqm commented Jul 2, 2021

@sftim That would be very difficult due to the fact that the several sources of kube-features are co-owned by many SIGs. One workaround, unlikely to happen though, is to have a working group supervising all feature changes. Such a working group may be sig-release or a different SIG dedicated to this cross-SIG coordination. Before that, we have to constantly remind the contributors to add/update documentation for feature stage changes. Otherwise, it falls on our shoulder to track these changes.

@sftim
Copy link
Contributor

sftim commented Jul 4, 2021 •
edited
Loading

Also relevant: issue #28787 (ControllerManagerLeaderMigration)

sftim
sftim reviewed Jul 4, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

(we can do a follow-up PR if we want to)

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 89a46fde0b66803a9b73b821758093a60dcf9ed1

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2021
@PI-Victor
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PI-Victor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8b51854 into kubernetes:dev-1.22 Jul 5, 2021
@XudongLiuHarold XudongLiuHarold mentioned this pull request Jul 20, 2021
Merged
@tengqm tengqm deleted the update-feature-gates branch July 28, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@PI-Victor PI-Victor

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@tengqm @sftim @PI-Victor @k8s-ci-robot