Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm/create-cluster: add warning about admin.conf #27141

Merged
merged 1 commit into from
Mar 30, 2021
Merged

kubeadm/create-cluster: add warning about admin.conf #27141

merged 1 commit into from
Mar 30, 2021

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Mar 19, 2021 •
edited
Loading

note: this is targetting dev-1.21 since the command kubeadm kubeconfig user is being promoted in 1.21.

Add warning that the file must not be shared as it has super powers
that cannot be revoked.

xref kubernetes/kubeadm#2414

/sig cluster-lifecycle

@neolit123
kubeadm/create-cluster: add warning about admin.conf
669322a 
Add warning that the file must not be shared as it has super powers
that cannot be revoked.
@k8s-ci-robot k8s-ci-robot added this to the 1.21 milestone Mar 19, 2021
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 669322a

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6054c8129260eb00082abe80

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2021
@neolit123 neolit123 mentioned this pull request Mar 19, 2021
Closed
6 tasks
SataQiu
SataQiu reviewed Mar 21, 2021
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5ace0adbe40142ac0b6f8e6083e0386ced24ab1d

@raesene
Copy link
Contributor

raesene commented Mar 22, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

@raesene: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@reylejano
Copy link
Member

/assign

@irvifa
Copy link
Member

irvifa commented Mar 30, 2021

Do we need technical review for this PR?

@neolit123
Copy link
Member Author

tech review passed: a couple of LGTM's were added above.

irvifa
irvifa reviewed Mar 30, 2021
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit b0f7615 into kubernetes:dev-1.21 Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu SataQiu left review comments

@irvifa irvifa irvifa left review comments

@jimangel jimangel Awaiting requested review from jimangel

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

Assignees

@SataQiu SataQiu

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.21
Development

Successfully merging this pull request may close these issues.
7 participants
@neolit123 @k8sio-netlify-preview-bot @k8s-ci-robot @raesene @reylejano @irvifa @SataQiu