Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable CAdvisor Json Metrics completed #26986

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Disable CAdvisor Json Metrics completed #26986

merged 1 commit into from
Mar 13, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Mar 10, 2021

@k8s-ci-robot k8s-ci-robot added this to the 1.21 milestone Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 58c9ddd

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60488d2a44aff000079ada81

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 10, 2021
@tengqm
Copy link
Contributor

tengqm commented Mar 10, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c322877e05c2edc413d00b782c504788e6e1a457

@joadavis
Copy link
Contributor

LGTM

SataQiu
SataQiu approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pacoxu
Copy link
Member Author

pacoxu commented Mar 12, 2021

/assign @tengqm

tanjunchen
tanjunchen reviewed Mar 12, 2021
View reviewed changes
Copy link
Member

@tanjunchen tanjunchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tengqm
Copy link
Contributor

tengqm commented Mar 13, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu, tanjunchen, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 10d8083 into kubernetes:dev-1.21 Mar 13, 2021
@pacoxu pacoxu deleted the remove/Disable-CAdvisor-Json-Metrics branch June 26, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjunchen tanjunchen tanjunchen left review comments

@SataQiu SataQiu SataQiu approved these changes

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@tengqm tengqm

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.21
Development

Successfully merging this pull request may close these issues.
7 participants
@pacoxu @k8sio-netlify-preview-bot @tengqm @k8s-ci-robot @joadavis @SataQiu @tanjunchen