-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mentions of kube-dns in kubeadm docs #26842
Remove mentions of kube-dns in kubeadm docs #26842
Conversation
Deploy preview for kubernetes-io-vnext-staging processing. Building with commit b957649 https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6046576d01658200070ca0a8 |
/cc @neolit123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/sig cluster-lifecycle
/lgtm
LGTM label has been added. Git tree hash: c4244307dc2261dcac1720040766d75eab0fb122
|
@@ -436,12 +436,12 @@ A ServiceAccount for `kube-proxy` is created in the `kube-system` namespace; the | |||
|
|||
#### DNS | |||
|
|||
- In Kubernetes version 1.18 kube-dns usage with kubeadm is deprecated and will be removed in a future release | |||
- In Kubernetes version 1.21 kube-dns usage with kubeadm has been removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd write:
- In Kubernetes version 1.21 kube-dns usage with kubeadm has been removed | |
- In Kubernetes version 1.21 support for using `kube-dns` with kubeadm was removed. | |
You can use CoreDNS with kubeadm even where the related Service is named `kube-dns`. |
and I'd put that statement at the end of the list. Readers are likely to be more interested in what is supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a language and Markdown perspective: changes LGTM.
@@ -328,7 +328,7 @@ and post-upgrade manifest file for a certain component, a backup file for it wil | |||
- Makes sure the control plane images are available or available to pull to the machine. | |||
- Generates replacements and/or uses user supplied overwrites if component configs require version upgrades. | |||
- Upgrades the control plane components or rollbacks if any of them fails to come up. | |||
- Applies the new `kube-dns` and `kube-proxy` manifests and makes sure that all necessary RBAC rules are created. | |||
- Applies the new `CoreDNS` and `kube-proxy` manifests and makes sure that all necessary RBAC rules are created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the manifest might still be called kube-dns
.
- A ServiceAccount for CoreDNS is created in the `kube-system` namespace. | ||
- The `coredns` ServiceAccount is bound to the privileges in the `system:coredns` ClusterRole | ||
|
||
- In Kubernetes version 1.21, support for using `kube-dns` with kubeadm is removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
- In Kubernetes version 1.21, support for using `kube-dns` with kubeadm is removed. | |
- In Kubernetes version 1.21, support for using `kube-dns` with kubeadm was removed. | |
- ``` |
/assign |
eeb83fd
to
b957649
Compare
1.21 Docs lead here. |
LGTM label has been added. Git tree hash: 29c40f808814ea9f72bcba7c12c1fec378b39f33
|
kubernetes/kubernetes#99646 is merged, so |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kubeadm is removing support for the deprecated kube-dns addon. This PR clears any mention of kube-dns from the kubeadm docs and also indicate that kube-dns is not supported from 1.21
Related to: kubernetes/kubeadm#1943