Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of kube-dns in kubeadm docs #26842

Merged
merged 3 commits into from
Mar 8, 2021

Conversation

rajansandeep
Copy link
Contributor

Kubeadm is removing support for the deprecated kube-dns addon. This PR clears any mention of kube-dns from the kubeadm docs and also indicate that kube-dns is not supported from 1.21

Related to: kubernetes/kubeadm#1943

@k8s-ci-robot k8s-ci-robot added this to the 1.21 milestone Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Mar 4, 2021

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit b957649

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6046576d01658200070ca0a8

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2021
@rajansandeep
Copy link
Contributor Author

/cc @neolit123

@k8s-ci-robot k8s-ci-robot requested a review from neolit123 March 4, 2021 17:09
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/sig cluster-lifecycle
/lgtm

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c4244307dc2261dcac1720040766d75eab0fb122

@@ -436,12 +436,12 @@ A ServiceAccount for `kube-proxy` is created in the `kube-system` namespace; the

#### DNS

- In Kubernetes version 1.18 kube-dns usage with kubeadm is deprecated and will be removed in a future release
- In Kubernetes version 1.21 kube-dns usage with kubeadm has been removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd write:

Suggested change
- In Kubernetes version 1.21 kube-dns usage with kubeadm has been removed
- In Kubernetes version 1.21 support for using `kube-dns` with kubeadm was removed.
You can use CoreDNS with kubeadm even where the related Service is named `kube-dns`.

and I'd put that statement at the end of the list. Readers are likely to be more interested in what is supported.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2021
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a language and Markdown perspective: changes LGTM.

@@ -328,7 +328,7 @@ and post-upgrade manifest file for a certain component, a backup file for it wil
- Makes sure the control plane images are available or available to pull to the machine.
- Generates replacements and/or uses user supplied overwrites if component configs require version upgrades.
- Upgrades the control plane components or rollbacks if any of them fails to come up.
- Applies the new `kube-dns` and `kube-proxy` manifests and makes sure that all necessary RBAC rules are created.
- Applies the new `CoreDNS` and `kube-proxy` manifests and makes sure that all necessary RBAC rules are created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the manifest might still be called kube-dns.

- A ServiceAccount for CoreDNS is created in the `kube-system` namespace.
- The `coredns` ServiceAccount is bound to the privileges in the `system:coredns` ClusterRole

- In Kubernetes version 1.21, support for using `kube-dns` with kubeadm is removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
- In Kubernetes version 1.21, support for using `kube-dns` with kubeadm is removed.
- In Kubernetes version 1.21, support for using `kube-dns` with kubeadm was removed.
- ```

@reylejano
Copy link
Member

/assign

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2021
@reylejano
Copy link
Member

1.21 Docs lead here.
I see that SIG Cluster Lifecycle chair (@neolit123) gave an lgtm before changes were added that removed the lgtm label.
SIG Docs tech lead (@sftim) gave an informal lgtm
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 29c40f808814ea9f72bcba7c12c1fec378b39f33

@sftim
Copy link
Contributor

sftim commented Mar 8, 2021

kubernetes/kubernetes#99646 is merged, so
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 74b2a80 into kubernetes:dev-1.21 Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants