Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix an invalid location.hash #26835

Merged
merged 1 commit into from
Mar 5, 2021
Merged

chore: fix an invalid location.hash #26835

merged 1 commit into from
Mar 5, 2021

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Mar 4, 2021

The current link results in redirection and location.hash does not work well.

The current link results in redirection and location.hash does not work well.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2021
@netlify
Copy link

netlify bot commented Mar 4, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3c4f29e

https://deploy-preview-26835--kubernetes-io-master-staging.netlify.app

@oke-py
Copy link
Contributor Author

oke-py commented Mar 4, 2021

/assign @onlydole

@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 5, 2021

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 5, 2021
@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 5, 2021

Thanks @oke-py .
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6503f5de56792c810a68368bf6080c73e998a5fe

@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 5, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit f40d7fd into kubernetes:master Mar 5, 2021
@oke-py oke-py deleted the invalid-hash branch March 5, 2021 01:30
ydFu added a commit to ydFu/website that referenced this pull request Mar 7, 2021
* Sync with english version in 'chore: fix an invalid location.hash (kubernetes#26835)'

Signed-off-by: ydFu <[email protected]>
ydFu added a commit to ydFu/website that referenced this pull request Mar 7, 2021
* Sync with english version in 'chore: fix an invalid location.hash (kubernetes#26835)'

Signed-off-by: ydFu <[email protected]>
ahg-g pushed a commit to ahg-g/website that referenced this pull request Mar 10, 2021
* Sync with english version in 'chore: fix an invalid location.hash (kubernetes#26835)'

Signed-off-by: ydFu <[email protected]>
s-kawamura-w664 pushed a commit to s-kawamura-w664/website that referenced this pull request Apr 22, 2021
* Sync with english version in 'chore: fix an invalid location.hash (kubernetes#26835)'

Signed-off-by: ydFu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants