Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ja: Make docs/setup/production-environment/windows/user-guide-windows-containhers.md follow v1.18 of the original text #26531

Conversation

task4233
Copy link
Contributor

@task4233 task4233 commented Feb 14, 2021

What would you like to be added
Update docs/setup/production-environment/windows/user-guide-windows-containers.md to follow v1.18 of the original (English) text.

Why is this needed
content/ja/docs/setup/production-environment/windows/user-guide-windows-containers.md is outdated.

Which issue(s) this PR fixes:
#26525

other diff has been resolved in #23124

…-containhers.md follow v1.18 of the original text
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 14, 2021
@task4233 task4233 changed the title ja: Make docs/setup/production-environment/windows/user-guide-windows… ja: Make docs/setup/production-environment/windows/user-guide-windows-containhers.md follow v1.18 of the original text Feb 14, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2021
@inductor
Copy link
Member

Hello. thank you for your contribution!
The original issue is still under evaluation by other reviewers as it has needs-triage label. so this PR will be reviewed after the evaluation process has done.

@nasa9084
Copy link
Member

/assign
/cc @makocchi-git @bells17 @kakts
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2021
@inductor
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor, nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inductor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6fdfc962b9be6e6e632af400206e5d288f27c7d6

@k8s-ci-robot k8s-ci-robot merged commit 44b5555 into kubernetes:dev-1.18-ja.2 Feb 15, 2021
@task4233 task4233 deleted the update-ja-setup-user-guide-windows-container branch February 15, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants