Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CRI-O docs to the latest configuration #26088

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Update CRI-O docs to the latest configuration #26088

merged 1 commit into from
Jan 14, 2021

Conversation

saschagrunert
Copy link
Member

This patch updates the CRI-O documentation to the latest available
version. It also adds a dedicated cgroup driver section to mention that
the configuration has to be in sync.

Refers to kubernetes/kubeadm#2376

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2021
@netlify
Copy link

netlify bot commented Jan 14, 2021 •
edited
Loading

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: ff9bcd4

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/600042e7d294e80008002508

😎 Browse the preview: https://deploy-preview-26088--kubernetes-io-master-staging.netlify.app

@saschagrunert
Copy link
Member Author

Preview: https://deploy-preview-26088--kubernetes-io-master-staging.netlify.app/docs/setup/production-environment/container-runtimes/#cri-o

@bart0sh
Copy link
Contributor

bart0sh commented Jan 14, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c91dae7593c1f77e67d64364aefec107b099292d

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2021
neolit123
neolit123 reviewed Jan 14, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/lgtm
/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jan 14, 2021
sftim
sftim reviewed Jan 14, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold

Feel free to unhold, and then maybe log a good-first-issue to fix what I think is a typo. Small issues like that are really useful to help new contributors get going. I prefer this approach!

Alternatively, feel free to revise based on the suggestion in this review and push the tweaked version.

content/en/docs/setup/production-environment/container-runtimes.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 14, 2021
@saschagrunert
Update CRI-O docs to the latest configuration
ff9bcd4 
This patch updates the CRI-O documentation to the latest available
version. It also adds a dedicated cgroup driver section to mention that
the configuration has to be in sync.

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2021
@saschagrunert
Copy link
Member Author

Yep, fixed the typo as suggested 👍

@sftim
Copy link
Contributor

sftim commented Jan 14, 2021

/lgtm
/approve

@sftim
Copy link
Contributor

sftim commented Jan 14, 2021

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cf49dcba66359e1bc75d0fbd30cc40aa95c94931

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4776608 into kubernetes:master Jan 14, 2021
@saschagrunert saschagrunert deleted the cri-o-docs branch January 14, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@neolit123 neolit123 neolit123 left review comments

@bart0sh bart0sh Awaiting requested review from bart0sh

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@neolit123 neolit123

@bart0sh bart0sh

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saschagrunert @bart0sh @k8s-ci-robot @sftim @neolit123