Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ja: Make docs/setup/production-environment/container-runtimes.md follow v1.18 of the original text #25347

Conversation

KobayashiD27
Copy link
Contributor

Update ja/docs/setup/production-environment/container-runtimes.md to follow the original text

Fix #25217

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2020
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 2, 2020
@KobayashiD27
Copy link
Contributor Author

/assign @inductor

echo 'deb http://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_Unstable/ /' > /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list
wget -nv https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/Debian_Unstable/Release.key -O- | sudo apt-key add -
```
CRI-O を以下の OS にインストールするには、環境変数 $OS を以下の表の適切なフィールドに設定します。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CRI-O を以下の OS にインストールするには、環境変数 $OS を以下の表の適切なフィールドに設定します
CRI-Oを以下のOSにインストールするには、環境変数$OSを以下の表の適切なフィールドに設定します

細かいところですが、英語と日本語の間のスペースは無くしておきましょうか
(他の部分も含めて)
それ以外は lgtm です

@kakts
Copy link
Member

kakts commented Dec 16, 2020

ご対応ありがとうございます!
#25347 (comment)
こちら修正いただければ lgtmです!

@KobayashiD27
Copy link
Contributor Author

レビューありがとうございます。余計なスペースを削除しました。確認したつもりですが、漏れがあったらすいません。

@kakts
Copy link
Member

kakts commented Dec 17, 2020

ご対応ありがとうございます!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 21792c4011fadc97184be670a42e314f05243cb7

@inductor
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9e62add into kubernetes:dev-1.18-ja.2 Dec 17, 2020
@KobayashiD27 KobayashiD27 deleted the update-setup-containerruntime branch March 24, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants