Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add documentation for CRI API moving to v1beta1 #24757

Closed
wants to merge 1 commit into from

Conversation

mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Oct 27, 2020

This is a placeholder PR for this enhancement: kubernetes/enhancements#2040

Signed-off-by: Mrunal Patel [email protected]

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 7ef4592

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f98a9f7afb17f00079ac32b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jimangel after the PR has been reviewed.
You can assign the PR to them by writing /assign @jimangel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2020
@somtochiama
Copy link
Member

/milestone 1.20

@k8s-ci-robot
Copy link
Contributor

@somtochiama: The provided milestone is not valid for this repository. Milestones in this repository: [1.18-ja.1, 1.18-ja.2, dev-1.19-ko.3, dev-1.19-ko.4]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@somtochiama
Copy link
Member

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 28, 2020
@annajung
Copy link
Contributor

/milestone 1.20

@k8s-ci-robot
Copy link
Contributor

@annajung: The provided milestone is not valid for this repository. Milestones in this repository: [1.18-ja.1, 1.18-ja.2, dev-1.19-ko.3, dev-1.19-ko.4]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/ documents a different kind of plugin API and might be useful as something to base the page upon.

Consider splitting the information added here into:

For the full PR, consider revising https://kubernetes.io/docs/setup/production-environment/container-runtimes/ either with links or with new text.

@@ -0,0 +1,25 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

(remove the leading blank line)


<!-- overview -->

{{< feature-state for_k8s_version="v1.20" state="beta" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this represent? Is this that Kubernetes supports the CRI, as a beta Kubernetes feature? Or that Kubernetes supports using [some set of versions of] the CRI API?

Maybe the CRI support in Kubernetes is beta and CRI itself is beta?

@somtochiama
Copy link
Member

/milestone 1.20

@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Oct 28, 2020
@annajung
Copy link
Contributor

annajung commented Nov 5, 2020

/assign @somtochiama

@sftim
Copy link
Contributor

sftim commented Nov 10, 2020

Hi @mrunalp

What help would you like towards getting this PR ready for review? Here in SIG Docs we'd really appreciate a chance to get as much reviewing done as we can before KubeCon.

@irvifa
Copy link
Member

irvifa commented Nov 12, 2020

Hi @mrunalp since this is been merged kubernetes/kubernetes#96387 and the rest will be on 1.21 wondering if there's something we could help so that we can proceed with this placeholder?

@mrunalp
Copy link
Contributor Author

mrunalp commented Nov 12, 2020

@irvifa, we will have to hold this till 1.21. We don't need doc updates in 1.20.

@annajung
Copy link
Contributor

@irvifa, we will have to hold this till 1.21. We don't need doc updates in 1.20.

Since this is no longer required, I'll close this PR. Feel free to reopen when the next release milestone and branch is available

/milestone clear
/close

@k8s-ci-robot k8s-ci-robot removed this from the 1.20 milestone Nov 12, 2020
@k8s-ci-robot
Copy link
Contributor

@annajung: Closed this PR.

In response to this:

@irvifa, we will have to hold this till 1.21. We don't need doc updates in 1.20.

Since this is no longer required, I'll close this PR. Feel free to reopen when the next release milestone and branch is available

/milestone clear
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants