-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add documentation for CRI API moving to v1beta1 #24757
Conversation
Signed-off-by: Mrunal Patel <[email protected]>
Deploy preview for kubernetes-io-vnext-staging processing. Building with commit 7ef4592 https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f98a9f7afb17f00079ac32b |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 1.20 |
@somtochiama: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig node |
/milestone 1.20 |
@annajung: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/ documents a different kind of plugin API and might be useful as something to base the page upon.
Consider splitting the information added here into:
- a new concept page
- a more detailed page inside https://kubernetes.io/docs/reference/
For the full PR, consider revising https://kubernetes.io/docs/setup/production-environment/container-runtimes/ either with links or with new text.
@@ -0,0 +1,25 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(remove the leading blank line)
|
||
<!-- overview --> | ||
|
||
{{< feature-state for_k8s_version="v1.20" state="beta" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this represent? Is this that Kubernetes supports the CRI, as a beta Kubernetes feature? Or that Kubernetes supports using [some set of versions of] the CRI API?
Maybe the CRI support in Kubernetes is beta and CRI itself is beta?
/milestone 1.20 |
/assign @somtochiama |
Hi @mrunalp What help would you like towards getting this PR ready for review? Here in SIG Docs we'd really appreciate a chance to get as much reviewing done as we can before KubeCon. |
Hi @mrunalp since this is been merged kubernetes/kubernetes#96387 and the rest will be on 1.21 wondering if there's something we could help so that we can proceed with this placeholder? |
@irvifa, we will have to hold this till 1.21. We don't need doc updates in 1.20. |
Since this is no longer required, I'll close this PR. Feel free to reopen when the next release milestone and branch is available /milestone clear |
@annajung: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a placeholder PR for this enhancement: kubernetes/enhancements#2040
Signed-off-by: Mrunal Patel [email protected]