Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description on concept overview ID page #24383

Merged
merged 5 commits into from
Oct 18, 2020
Merged

Add description on concept overview ID page #24383

merged 5 commits into from
Oct 18, 2020

Conversation

WilliamChang80
Copy link
Contributor

I've added some description in page https://kubernetes.io/id/docs/concepts/overview/ based on main page in https://kubernetes.io/docs/concepts/overview/. I also removed object management part on /overview directory because currently, its not used on main site

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 5, 2020
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 5, 2020
@WilliamChang80
Copy link
Contributor Author

/assign @irvifa

@irvifa
Copy link
Member

irvifa commented Oct 5, 2020

Why there’s lots of deleted pages there?

@WilliamChang80
Copy link
Contributor Author

WilliamChang80 commented Oct 5, 2020 •
edited
Loading

Why there’s lots of deleted pages there?

Because for object management session its not used on en page for now and its not exist on the https://kubernetes.io/docs/concepts/overview/

Or should i keep it instead of deleting it?

@netlify
Copy link

netlify bot commented Oct 5, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 57e0250

https://deploy-preview-24383--kubernetes-io-master-staging.netlify.app

@danninov
Copy link
Contributor

danninov commented Oct 5, 2020

Why there’s lots of deleted pages there?

Because for object management session its not used on en page for now and its not exist on the https://kubernetes.io/docs/concepts/overview/

Or should i keep it instead of deleting it?

All pages in concept/overview/object-management-kubectl is moved to tasks/manage-kubernetes-objects/ in this PR #14481. Please move those pages to task folder and fix links in related pages.

@irvifa
Copy link
Member

irvifa commented Oct 5, 2020

Before deleting a document I think it’s encouraged to check whether the docs is moved into different link or not. 🙂 Please fix this accordingly.

@WilliamChang80
Copy link
Contributor Author

I see, thank you for the reminder. I'll fix it soon

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 5, 2020
@WilliamChang80
Copy link
Contributor Author

I've updated it, feel free to drop comments if there are any suggestion or mistakes 😃

@WilliamChang80
Copy link
Contributor Author

Is there any update on this PR?

irvifa
irvifa reviewed Oct 18, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 573fd0bfafb40a58cbf1dfaaa7f67fcfee52e44e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa, WilliamChang80

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit b48179c into kubernetes:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvifa irvifa irvifa left review comments

@danninov danninov Awaiting requested review from danninov

@wahyuoi wahyuoi Awaiting requested review from wahyuoi

Assignees

@irvifa irvifa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WilliamChang80 @irvifa @danninov @k8s-ci-robot