Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for ServiceAccountIssuerDiscovery beta #23887

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Sep 14, 2020

ServiceAccountIssuerDiscovery is going beta in 1.20.
This updates the feature status in docs.

Enhancement: kubernetes/enhancements#1393

This PR replaces: #21593

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Sep 14, 2020

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit da08874

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f61029e8921e00007b7f740

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2020
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 14, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 14, 2020
@mtaufen
Copy link
Contributor Author

mtaufen commented Sep 14, 2020

/assign @sftim

@sftim
Copy link
Contributor

sftim commented Sep 15, 2020

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Sep 15, 2020
@sftim
Copy link
Contributor

sftim commented Sep 15, 2020

/milestone 1.20

@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Sep 15, 2020
@tengqm
Copy link
Contributor

tengqm commented Sep 16, 2020

/approve
Deferring another LGTM to @sftim.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2020
@annajung
Copy link
Contributor

annajung commented Oct 2, 2020

/assign @annajung

@annajung
Copy link
Contributor

friendly ping to @sftim to review this when you can

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the wait - I missed this
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 42c3de8f0defef15ff368992c9d6b186911efa27

@sftim sftim dismissed their stale review October 14, 2020 13:55

Superseded

@k8s-ci-robot k8s-ci-robot merged commit f1ac8ef into kubernetes:dev-1.20 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants