Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update glossary #22796

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Update glossary #22796

merged 1 commit into from
Jul 28, 2020
+11 −11

Conversation

inductor
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2020
@inductor inductor changed the title glossary Update glossary Jul 28, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 28, 2020
@k8s-ci-robot k8s-ci-robot requested review from nasa9084 and oke-py July 28, 2020 01:11
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 28, 2020
oke-py
oke-py approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@oke-py oke-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2020
@oke-py oke-py removed their assignment Jul 28, 2020
@inductor
Copy link
Member Author

/assign @nasa9084

nasa9084
nasa9084 reviewed Jul 28, 2020
View reviewed changes
Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@nasa9084
Copy link
Member

/cc @bells17
/uncc

@k8s-ci-robot k8s-ci-robot requested a review from bells17 July 28, 2020 01:35
@k8s-ci-robot k8s-ci-robot merged commit f6b5222 into kubernetes:dev-1.17-ja.3 Jul 28, 2020
@inductor inductor deleted the feature/glossary branch July 28, 2020 01:49
@inductor inductor mentioned this pull request Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nasa9084 nasa9084 nasa9084 left review comments

@oke-py oke-py oke-py approved these changes

@bells17 bells17 Awaiting requested review from bells17

Assignees

@nasa9084 nasa9084

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@inductor @k8s-ci-robot @nasa9084 @oke-py