Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate tasks/configure-pod-container/extended-resource into Japanese #22696

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Translate tasks/configure-pod-container/extended-resource into Japanese #22696

merged 4 commits into from
Jul 30, 2020

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Jul 24, 2020 •
edited
Loading

Closes #22689

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/ja Issues or PRs related to Japanese language labels Jul 24, 2020
@k8s-ci-robot k8s-ci-robot requested review from bells17 and nasa9084 July 24, 2020 09:51
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 24, 2020
@shuuji3
Copy link
Contributor Author

shuuji3 commented Jul 24, 2020

/assign @inductor

bells17
bells17 reviewed Jul 25, 2020
View reviewed changes
Copy link
Contributor

@bells17 bells17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1点コメントしました

@bells17 bells17 mentioned this pull request Jul 25, 2020
Merged
@shuuji3 shuuji3 force-pushed the tasks/configure-pod-container/extended-resource branch from 1cf5310 to 6931dd9 Compare July 28, 2020 10:36
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language language/id Issues or PRs related to Indonesian language language/zh Issues or PRs related to Chinese language size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2020
@shuuji3 shuuji3 changed the base branch from dev-1.17-ja.3 to master July 28, 2020 10:37
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 28, 2020
@shuuji3
Copy link
Contributor Author

shuuji3 commented Jul 28, 2020

/remove-area blog
/remove-language en
/remove-language id
/remove-language zh

@k8s-ci-robot k8s-ci-robot removed area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language language/id Issues or PRs related to Indonesian language language/zh Issues or PRs related to Chinese language labels Jul 28, 2020
@shuuji3 shuuji3 changed the base branch from master to dev-1.17-ja.3 July 28, 2020 10:46
@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 28, 2020
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 28, 2020
@shuuji3 shuuji3 force-pushed the tasks/configure-pod-container/extended-resource branch from 6931dd9 to c989af5 Compare July 28, 2020 10:48
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 28, 2020
@shuuji3
Copy link
Contributor Author

shuuji3 commented Jul 28, 2020

ごちゃごちゃしてしまいましたが、マージ準備できました。
こちらは #22706 と同じく dev-1.17-ja.3 がターゲットでよかったですか？

@oke-py
Copy link
Contributor

oke-py commented Jul 28, 2020

@shuuji3 このページの原文は、release-1.17とmasterの間に新テーマ対応の差分しかありません。
内容としては変わらないため、dev-1.17-ja.3で大丈夫です。

@kakts
Copy link
Member

kakts commented Jul 29, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2020
inductor
inductor approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@inductor inductor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4fb83b8 into kubernetes:dev-1.17-ja.3 Jul 30, 2020
@inductor inductor mentioned this pull request Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bells17 bells17 bells17 left review comments

@inductor inductor inductor approved these changes

@nasa9084 nasa9084 Awaiting requested review from nasa9084

Assignees

@kakts kakts

@inductor inductor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate tasks/configure-pod-container/extended-resource/ into Japanese
6 participants
@shuuji3 @oke-py @kakts @k8s-ci-robot @bells17 @inductor