Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate tutorials/services/source-ip into Japanese #22668

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Translate tutorials/services/source-ip into Japanese #22668

merged 2 commits into from
Jul 28, 2020

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Jul 23, 2020

Closes #22666.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 23, 2020
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2020
@shuuji3
Copy link
Contributor Author

shuuji3 commented Jul 23, 2020

/assign @inductor

@shuuji3 shuuji3 force-pushed the tutorials/services/source-ip branch from bd93b17 to f0f0908 Compare July 24, 2020 06:08
@k8s-ci-robot
Copy link
Contributor

@makocchi-ca: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@makocchi-git
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2020
@inductor
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0f54fcd into kubernetes:dev-1.17-ja.3 Jul 28, 2020
@shuuji3 shuuji3 deleted the tutorials/services/source-ip branch July 28, 2020 11:22
@inductor inductor mentioned this pull request Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@bells17 bells17 Awaiting requested review from bells17

@makocchi-git makocchi-git Awaiting requested review from makocchi-git

Assignees

@makocchi-git makocchi-git

@inductor inductor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shuuji3 @k8s-ci-robot @makocchi-git @inductor @sftim