Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Troubleshooting kubeadm #22631

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Update Troubleshooting kubeadm #22631

merged 1 commit into from
Jul 22, 2020

Conversation

inductor
Copy link
Member

Closes #22366

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language labels Jul 21, 2020
@k8s-ci-robot k8s-ci-robot requested review from bells17 and oke-py July 21, 2020 22:37
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2020
oke-py
oke-py approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@oke-py oke-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2020
@oke-py oke-py removed their assignment Jul 22, 2020
@nasa9084
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3c4ca7a into kubernetes:dev-1.17-ja.3 Jul 22, 2020
@inductor inductor deleted the feature/update_troubleshooting_adm branch July 22, 2020 03:32
@inductor inductor mentioned this pull request Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oke-py oke-py oke-py approved these changes

@bells17 bells17 Awaiting requested review from bells17

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@inductor @nasa9084 @k8s-ci-robot @oke-py