Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization ja #22409

Merged
merged 12 commits into from
Jul 10, 2020
Merged

Localization ja #22409

merged 12 commits into from
Jul 10, 2020

Conversation

inductor
Copy link
Member

@inductor inductor commented Jul 7, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/ja Issues or PRs related to Japanese language labels Jul 7, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 7, 2020
@netlify
Copy link

netlify bot commented Jul 7, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 80b31db

https://deploy-preview-22409--kubernetes-io-master-staging.netlify.app

@kakts
Copy link
Member

kakts commented Jul 7, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2020
nasa9084
nasa9084 reviewed Jul 9, 2020
View reviewed changes
content/ja/docs/contribute/localization.md Outdated Show resolved Hide resolved
content/ja/docs/contribute/localization.md Outdated Show resolved Hide resolved
content/ja/docs/contribute/localization.md Outdated Show resolved Hide resolved
content/ja/docs/contribute/localization.md Outdated Show resolved Hide resolved
content/ja/docs/contribute/localization.md Outdated Show resolved Hide resolved
content/ja/docs/contribute/localization.md Outdated Show resolved Hide resolved
content/ja/docs/contribute/localization.md Outdated Show resolved Hide resolved
content/ja/docs/contribute/localization.md Outdated Show resolved Hide resolved
content/ja/docs/contribute/localization.md Show resolved Hide resolved
content/ja/docs/contribute/localization.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2020
inductor and others added 10 commits July 9, 2020 16:48
localize localization
65c6894
update version
546fca3
@nasa9084
Update content/ja/docs/contribute/localization.md
c241609 
Co-authored-by: nasa9084 <[email protected]>
@nasa9084
Update content/ja/docs/contribute/localization.md
a677e2f 
Co-authored-by: nasa9084 <[email protected]>
@nasa9084
Update content/ja/docs/contribute/localization.md
bfe6a49 
Co-authored-by: nasa9084 <[email protected]>
@nasa9084
Update content/ja/docs/contribute/localization.md
7e4093b 
Co-authored-by: nasa9084 <[email protected]>
@nasa9084
Update content/ja/docs/contribute/localization.md
34dbe18 
Co-authored-by: nasa9084 <[email protected]>
@nasa9084
Update content/ja/docs/contribute/localization.md
da5b6d7 
Co-authored-by: nasa9084 <[email protected]>
@nasa9084
Update content/ja/docs/contribute/localization.md
addcdd9 
Co-authored-by: nasa9084 <[email protected]>
@nasa9084
Update content/ja/docs/contribute/localization.md
51e9f78 
Co-authored-by: nasa9084 <[email protected]>
@inductor inductor requested a review from nasa9084 July 9, 2020 14:13
@nasa9084
Copy link
Member

/assign

@nasa9084
Copy link
Member

/approve

@nasa9084
Copy link
Member

/cc @oke-py

@k8s-ci-robot k8s-ci-robot requested a review from oke-py July 10, 2020 02:36
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@nasa9084
Copy link
Member

/cc @bells17

@k8s-ci-robot k8s-ci-robot requested a review from bells17 July 10, 2020 02:36
@bells17
Copy link
Contributor

bells17 commented Jul 10, 2020

/lgtm

issueとかが切られていないのですが、変更背景やどうしたいための変更なのかは(元々はDMでのやり取りから発生してたんだけど)
https://kubernetes.slack.com/archives/C016LL2HF61/p1594127545004300
にまとまっていて

・古いものを追従するパターンについては今まで通りバージョンを切りながら追っていく（定期的にmasterから分かれるので、追従するものだけそのブランチに集中管理できる）
・新規の翻訳の場合はmasterから直接切って最新版を翻訳する
古いとわかってるものをわざわざ古く翻訳する手間や、新しい機能を早く試したいと思っている人たちに情報が届けられないのがあまり良くないなと思っていて、多少の管理の手間を犠牲にしてでもこのくらいのやり方にしたほうが良さそうかもなっていう気持ち
これを採用する場合に思い浮かぶデメリットとしては
・ブランチが分かれるところは少しルールが複雑になる（ただし、これに関してはもともとのmasterにPR送らないっていうルールも十分初めての人にとっては複雑だと思う）
・masterに取り込むまでの時間が短いので中身が間違ってたときにすぐ本番に反映される（わかった時点でhotfix切れば良いと思う）

という理解でいます

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit ccc0444 into kubernetes:master Jul 10, 2020
@inductor inductor deleted the localization_ja branch July 19, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makocchi-git makocchi-git Awaiting requested review from makocchi-git

@nasa9084 nasa9084 Awaiting requested review from nasa9084

@oke-py oke-py Awaiting requested review from oke-py

@bells17 bells17 Awaiting requested review from bells17

Assignees

@bells17 bells17

@nasa9084 nasa9084

@kakts kakts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@inductor @kakts @nasa9084 @k8s-ci-robot @bells17