Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update components.md for v1.17 #21905

Merged
merged 3 commits into from
Jun 20, 2020
Merged

Update components.md for v1.17 #21905

merged 3 commits into from
Jun 20, 2020

Conversation

hikkie3110
Copy link
Contributor

fix #21841

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2020
@k8s-ci-robot k8s-ci-robot requested review from nasa9084 and oke-py June 19, 2020 10:38
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 19, 2020
oke-py
oke-py suggested changes Jun 19, 2020
View reviewed changes
content/ja/docs/concepts/overview/components.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/overview/components.md Outdated Show resolved Hide resolved
oke-py
oke-py approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@oke-py oke-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2020
@oke-py oke-py removed their assignment Jun 20, 2020
@oke-py
Copy link
Contributor

oke-py commented Jun 20, 2020

/assign @inductor

@inductor
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit f9fb259 into kubernetes:dev-1.17-ja.3 Jun 20, 2020
@inductor inductor mentioned this pull request Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oke-py oke-py oke-py approved these changes

@nasa9084 nasa9084 Awaiting requested review from nasa9084

Assignees

@inductor inductor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hikkie3110 @oke-py @inductor @k8s-ci-robot