Add Scheduling Configuration reference doc #21437

alculquicondor · 2020-06-02T20:34:22Z

kubernetes/enhancements#1451
kubernetes/enhancements#785

Updates include:

Changes from v1alpha2
New VolumeBinding extension points
Redirect from old path

k8sio-netlify-preview-bot · 2020-06-02T20:34:25Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 9ed3f42

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f0489b67e14fa000717a31d

sftim · 2020-06-02T21:09:31Z

/sig scheduling

sftim

Some early / informal feedback

content/en/docs/reference/scheduling/config.md

alculquicondor · 2020-06-03T15:12:42Z

Thanks all for the feedback. This PR is still WIP, but section header and id is now in its intended state.

savitharaghunathan · 2020-06-03T18:18:51Z

/milestone 1.19

savitharaghunathan · 2020-07-01T13:38:23Z

Hi @alculquicondor 👋 , Please rebase your PR to avoid major merge conflicts :) Thanks!

alculquicondor · 2020-07-06T20:04:30Z

/assign @Huang-Wei

cc @pancernik

content/en/docs/reference/scheduling/config.md

Built from the existing Scheduling Profiles doc. Signed-off-by: Aldo Culquicondor <[email protected]>

sftim

Markdown looks OK to me.

The new text:

The KubeSchedulerConfiguration is a configuration API for kube-scheduler
that can be provided as a file via --config command line flag.

could be a bit confusing to readers, but if this merges as-is I'm fine with that.

@alculquicondor you can revise again or move forward towards a technical LGTM and either approach works for me.

content/en/docs/reference/scheduling/config.md

static/_redirects

Signed-off-by: Aldo Culquicondor <[email protected]>

ahg-g · 2020-07-06T21:34:56Z

Latest revision looks good to me.

sftim · 2020-07-06T21:47:01Z

I'm not sure who is reviewing for SIG Scheduling. I think that this should have technical review (and I also hope that this is easy to review).

@kubernetes/sig-scheduling-pr-reviews this is ~~reach~~ ready for tech review. Please /lgtm when happy.

sftim · 2020-07-06T21:49:37Z

Preview: Scheduler Configuration

alculquicondor · 2020-07-06T22:08:14Z

@ahg-g mind giving lgtm?

ahg-g · 2020-07-06T22:36:51Z

/lgtm

Tin, I already reviewed the PR

Huang-Wei

Sry for the late review. Some nits.

content/en/docs/reference/scheduling/config.md

Huang-Wei · 2020-07-06T23:13:14Z

content/en/docs/reference/scheduling/config.md

@@ -33,33 +44,57 @@ extension points:
   sort pending Pods in the scheduling queue. Exactly one queue sort plugin
   may be enabled at a time.
 1. `PreFilter`: These plugins are used to pre-process or check information
-   about a Pod or the cluster before filtering.
+   about a Pod or the cluster before filtering. They can mark a pod as
+   unschedulable.
 1. `Filter`: These plugins are the equivalent of Predicates in a scheduling


I will submit another PR finishing the PostFilter part.

Huang-Wei · 2020-07-06T23:20:46Z

content/en/docs/reference/scheduling/config.md

+          weight: 1
+```
+
+You can use `*`  as name in the disabled array to disable all default plugins


Suggested change

You can use `*` as name in the disabled array to disable all default plugins

You can use `*` as name in the disabled array to disable all default plugins

content/en/docs/reference/scheduling/config.md

savitharaghunathan · 2020-07-07T00:06:59Z

/assign

cofyc · 2020-07-07T01:40:01Z

cc @cofyc for VolumeBinding changes

VolumeBinding changes LGTM

pancernik · 2020-07-07T12:04:05Z

content/en/docs/reference/scheduling/config.md

+      score:
+        disabled:
+        - name: '*'
+```


Would it make sense to explain this example? For example by adding a paragraph:

The example above will configure kube-scheduler to run two schedulers: the default one and no-scoring-scheduler with the score extension point disabled for all plugins.

Good suggestion

this is interesting, so are we saying we will be able to use the same scheduler binary to act as two different schedulers based on the scheduler field in the Pod ?

Signed-off-by: Aldo Culquicondor <[email protected]>

pancernik · 2020-07-07T15:32:37Z

LGTM

alculquicondor · 2020-07-08T17:46:58Z

@savitharaghunathan or @sftim anything else for approval?

sftim · 2020-07-08T17:56:26Z

Changes since #21437 (comment) look good to me
/lgtm

savitharaghunathan

/approve

k8s-ci-robot · 2020-07-08T18:09:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitharaghunathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [savitharaghunathan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2020

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2020

k8s-ci-robot requested review from jimangel and sftim June 2, 2020 20:34

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 2, 2020

This was referenced Jun 2, 2020

Remove KubeSchedulerConfiguration.BindTimeoutSeconds kubernetes/kubernetes#91580

Merged

Run multiple Scheduling Profiles kubernetes/enhancements#1451

Closed

Graduate the kube-scheduler ComponentConfig to GA kubernetes/enhancements#785

Closed

alculquicondor force-pushed the beta-component-config branch from f8accec to 1c3a600 Compare June 2, 2020 20:43

k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jun 2, 2020

sftim reviewed Jun 2, 2020

View reviewed changes

content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved

content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved

alculquicondor force-pushed the beta-component-config branch from 1c3a600 to 0fb8777 Compare June 3, 2020 15:11

k8s-ci-robot added this to the 1.19 milestone Jun 3, 2020

alculquicondor mentioned this pull request Jun 5, 2020

Promote kubescheduler.config.k8s.io to v1betav1 kubernetes/kubernetes#91420

Merged

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2020

alculquicondor force-pushed the beta-component-config branch from 0fb8777 to 023782d Compare July 6, 2020 20:03

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2020

k8s-ci-robot assigned Huang-Wei Jul 6, 2020

alculquicondor changed the title ~~WIP: Add Scheduling Configuration reference doc~~ Add Scheduling Configuration reference doc Jul 6, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2020

alculquicondor force-pushed the beta-component-config branch from 023782d to 86cbfe2 Compare July 6, 2020 20:11

alculquicondor force-pushed the beta-component-config branch from 86cbfe2 to c890227 Compare July 6, 2020 20:25

adtac reviewed Jul 6, 2020

View reviewed changes

content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved

Add Scheduling Configuration reference doc

72090c9

Built from the existing Scheduling Profiles doc. Signed-off-by: Aldo Culquicondor <[email protected]>

alculquicondor force-pushed the beta-component-config branch from c890227 to 72090c9 Compare July 6, 2020 20:32

sftim reviewed Jul 6, 2020

View reviewed changes

content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved

content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved

content/en/docs/reference/scheduling/config.md Outdated Show resolved Hide resolved

static/_redirects Show resolved Hide resolved

Review comments

34c3537

Signed-off-by: Aldo Culquicondor <[email protected]>

k8s-ci-robot assigned ahg-g Jul 6, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2020

Huang-Wei reviewed Jul 6, 2020

View reviewed changes

k8s-ci-robot assigned savitharaghunathan Jul 7, 2020

pancernik reviewed Jul 7, 2020

View reviewed changes

Review comments 2

9ed3f42

Signed-off-by: Aldo Culquicondor <[email protected]>

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2020

Huang-Wei mentioned this pull request Jul 8, 2020

Remove DisablePreemption field from KubeSchedulerConfiguration kubernetes/kubernetes#92892

Merged

k8s-ci-robot assigned sftim Jul 8, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2020

savitharaghunathan reviewed Jul 8, 2020

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020

k8s-ci-robot merged commit 754c6b1 into kubernetes:dev-1.19 Jul 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Scheduling Configuration reference doc #21437

Add Scheduling Configuration reference doc #21437

alculquicondor commented Jun 2, 2020 •

edited

Loading

k8sio-netlify-preview-bot commented Jun 2, 2020 •

edited

Loading

sftim commented Jun 2, 2020

sftim left a comment

alculquicondor commented Jun 3, 2020

savitharaghunathan commented Jun 3, 2020

savitharaghunathan commented Jul 1, 2020

alculquicondor commented Jul 6, 2020

sftim left a comment

ahg-g commented Jul 6, 2020

sftim commented Jul 6, 2020 •

edited

Loading

sftim commented Jul 6, 2020

alculquicondor commented Jul 6, 2020

ahg-g commented Jul 6, 2020

Huang-Wei left a comment

Huang-Wei Jul 6, 2020

Huang-Wei Jul 6, 2020

savitharaghunathan commented Jul 7, 2020

cofyc commented Jul 7, 2020

pancernik Jul 7, 2020

alculquicondor Jul 7, 2020

krmayankk Aug 27, 2020

ahg-g Aug 27, 2020

pancernik commented Jul 7, 2020

alculquicondor commented Jul 8, 2020

sftim commented Jul 8, 2020

savitharaghunathan left a comment

k8s-ci-robot commented Jul 8, 2020

	You can use `*` as name in the disabled array to disable all default plugins
	You can use `*` as name in the disabled array to disable all default plugins

Add Scheduling Configuration reference doc #21437

Add Scheduling Configuration reference doc #21437

Conversation

alculquicondor commented Jun 2, 2020 • edited Loading

k8sio-netlify-preview-bot commented Jun 2, 2020 • edited Loading

sftim commented Jun 2, 2020

sftim left a comment

Choose a reason for hiding this comment

alculquicondor commented Jun 3, 2020

savitharaghunathan commented Jun 3, 2020

savitharaghunathan commented Jul 1, 2020

alculquicondor commented Jul 6, 2020

sftim left a comment

Choose a reason for hiding this comment

ahg-g commented Jul 6, 2020

sftim commented Jul 6, 2020 • edited Loading

sftim commented Jul 6, 2020

alculquicondor commented Jul 6, 2020

ahg-g commented Jul 6, 2020

Huang-Wei left a comment

Choose a reason for hiding this comment

Huang-Wei Jul 6, 2020

Choose a reason for hiding this comment

Huang-Wei Jul 6, 2020

Choose a reason for hiding this comment

savitharaghunathan commented Jul 7, 2020

cofyc commented Jul 7, 2020

pancernik Jul 7, 2020

Choose a reason for hiding this comment

alculquicondor Jul 7, 2020

Choose a reason for hiding this comment

krmayankk Aug 27, 2020

Choose a reason for hiding this comment

ahg-g Aug 27, 2020

Choose a reason for hiding this comment

pancernik commented Jul 7, 2020

alculquicondor commented Jul 8, 2020

sftim commented Jul 8, 2020

savitharaghunathan left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 8, 2020

alculquicondor commented Jun 2, 2020 •

edited

Loading

k8sio-netlify-preview-bot commented Jun 2, 2020 •

edited

Loading

sftim commented Jul 6, 2020 •

edited

Loading