Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated config.toml as part of release-1.18 #19843

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Updated config.toml as part of release-1.18 #19843

merged 1 commit into from
Mar 27, 2020

Conversation

VineethReddy02
Copy link
Contributor

Updated config.toml

@VineethReddy02 VineethReddy02 requested a review from jimangel March 25, 2020 20:50
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 25, 2020
@sftim
Copy link
Contributor

sftim commented Mar 25, 2020

Helps with issue #19841

sftim
sftim reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2020
@jimangel
Copy link
Member

Same as the other issue, I do not see 1.18 in the dropdown.

https://deploy-preview-19843--k8s-v1-14.netlify.com/

@sftim
Copy link
Contributor

sftim commented Mar 25, 2020

Should have checked more. Following #19843 (comment)
/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2020
@VineethReddy02 VineethReddy02 force-pushed the vineeth-update-config.toml-for-release-1.14 branch from d7f117a to 082cb81 Compare March 26, 2020 11:02
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2020
@kbhawkey
Copy link
Contributor

Preview looks okay, https://deploy-preview-19843--k8s-v1-14.netlify.com/
The "maintenance" banner text is formatted nicely in the 1.14 version compared to >= 1.16.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2020
@jimangel
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9764a08 into kubernetes:release-1.14 Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@jimangel jimangel Awaiting requested review from jimangel

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@kbhawkey kbhawkey

@jimangel jimangel

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VineethReddy02 @sftim @jimangel @kbhawkey @k8s-ci-robot