-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update urls in zh docs default-storage-class-prereqs.md #19396
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 2bad689 https://deploy-preview-19396--kubernetes-io-master-staging.netlify.com |
@@ -1,4 +1,4 @@ | |||
您需要有一个带有默认[StorageClass](/docs/concepts/storage/storage-classes/)的动态持续卷供应程序,或者自己[静态的提供持久卷](/docs/user-guide/persistent-volumes/#provisioning)来满足这里使用的[持久卷请求](/docs/user-guide/persistent-volumes/#persistentvolumeclaims)。 | |||
您需要有一个带有默认[StorageClass](/content/zh/docs/concepts/storage/storage-classes.md)的动态持续卷供应程序,或者自己[静态的提供持久卷](/content/zh/docs/reference/glossary/persistent-volume.md)来满足这里使用的[持久卷请求](/content/zh/docs/reference/glossary/persistent-volume-claim.md)。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Most zh translation docs still keep the links to en version. A general fix for this is under discussion.
- No need for
.md
in a link.
@@ -71,23 +71,3 @@ kubeadm init phase control-plane [flags] | |||
</tbody> | |||
</table> | |||
|
|||
|
|||
|
|||
<!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, one PR better has one purpose. The see also
issue seems to have its own tracking issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
for this change
I remember that this issue (removing SEE ALSO ) has been closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #18411
@zhanw15 Still working on this? |
@tengqm Yes, I'm focusing on this |
/close |
@tengqm: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
url has been changed.