Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update urls in zh docs default-storage-class-prereqs.md #19396

Closed
wants to merge 2 commits into from
Closed

update urls in zh docs default-storage-class-prereqs.md #19396

wants to merge 2 commits into from

Conversation

zhanw15
Copy link
Contributor

@zhanw15 zhanw15 commented Feb 29, 2020

url has been changed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign xiangpengzhao
You can assign the PR to them by writing /assign @xiangpengzhao in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 29, 2020
@netlify
Copy link

netlify bot commented Feb 29, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2bad689

https://deploy-preview-19396--kubernetes-io-master-staging.netlify.com

@zhanw15 zhanw15 changed the title update urls in default-storage-class-prereqs.md update urls in zh docs default-storage-class-prereqs.md Feb 29, 2020
@@ -1,4 +1,4 @@
您需要有一个带有默认[StorageClass](/docs/concepts/storage/storage-classes/)的动态持续卷供应程序,或者自己[静态的提供持久卷](/docs/user-guide/persistent-volumes/#provisioning)来满足这里使用的[持久卷请求](/docs/user-guide/persistent-volumes/#persistentvolumeclaims)。
您需要有一个带有默认[StorageClass](/content/zh/docs/concepts/storage/storage-classes.md)的动态持续卷供应程序,或者自己[静态的提供持久卷](/content/zh/docs/reference/glossary/persistent-volume.md)来满足这里使用的[持久卷请求](/content/zh/docs/reference/glossary/persistent-volume-claim.md)。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Most zh translation docs still keep the links to en version. A general fix for this is under discussion.
  2. No need for .md in a link.

@@ -71,23 +71,3 @@ kubeadm init phase control-plane [flags]
</tbody>
</table>



<!--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, one PR better has one purpose. The see also issue seems to have its own tracking issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
for this change
I remember that this issue (removing SEE ALSO ) has been closed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #18411

@tengqm
Copy link
Contributor

tengqm commented Mar 28, 2020

@zhanw15 Still working on this?

@zhanw15
Copy link
Contributor Author

zhanw15 commented Mar 31, 2020

@tengqm Yes, I'm focusing on this

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2020
@tengqm
Copy link
Contributor

tengqm commented Apr 10, 2020

/close
This PR has been dangling for too long. Please feel free to reopen it when time permits.

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closed this PR.

In response to this:

/close
This PR has been dangling for too long. Please feel free to reopen it when time permits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants