-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cri-o version must match the k8 version #19092
Conversation
It's not clear from the doc that the cri-o version must match the k8 version as shown in the cri-o compatibility matrix.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @larntz-tbc! |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 31d3e8e https://deploy-preview-19092--kubernetes-io-master-staging.netlify.com |
Signed CLA |
/assign @daminisatya |
@@ -160,7 +160,7 @@ for more information. | |||
|
|||
This section contains the necessary steps to install `CRI-O` as CRI runtime. | |||
|
|||
Use the following commands to install CRI-O on your system: | |||
Use the following commands to install CRI-O on your system (but be sure the major/minor version of CRI-O matches the major/minor version of kubernetes (see the [cri-o compatiblity matrix](https://github.com/cri-o/cri-o)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @larntz-tbc . Thanks for opening this PR.
What do you think about adding a note shortcode (with the compatibility information) after line 161, such as:
{{< note >}}
The CRI-O major and minor versions must match the Kubernetes major and minor versions.
For more information, see the [CRI-O compatiblity matrix](https://github.com/cri-o/cri-o).
{{< /note >}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a great idea. I wasn't sure what the best way to format it was, but felt like the additional information was important.
Thank you for the suggestion!
Edit: Do I need to do something to change this? Not sure exactly how that works. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@larntz-tbc, Yes, depending on how you created this pull request, you should create another commit on your branch (in your local repository) and push the changes again, git push origin <your branch>
.
The Kubernetes Intermediate Contributing
docs describes how to work locally,
https://kubernetes.io/docs/contribute/intermediate/#work-on-the-local-repository .
Let me know if you need help sorting out the process 😃 .
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@larntz-tbc , looks like your second commit is from a different user account. |
You may need to drop that commit and recreate the commit using your authorized account. |
I think I was able to fix it. Let me know if I need to do anything else. Thanks for all your help! |
Use the following commands to install CRI-O on your system (but be sure the major/minor version of CRI-O matches the major/minor version of kubernetes (see the [cri-o compatiblity matrix](https://github.com/cri-o/cri-o)): | ||
Use the following commands to install CRI-O on your system: | ||
|
||
{{< note >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@larntz-tbc , Changes look good. I would have placed the note before Line 163, but seems fine as is.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbhawkey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* cri-o version must match the k8 version It's not clear from the doc that the cri-o version must match the k8 version as shown in the cri-o compatibility matrix. * changed to note shortcode for cri-o compat matrix - fix author
* cri-o version must match the k8 version It's not clear from the doc that the cri-o version must match the k8 version as shown in the cri-o compatibility matrix. * changed to note shortcode for cri-o compat matrix - fix author
It's not clear from the doc that the cri-o version must match the k8 version as shown in the cri-o compatibility matrix.