Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to {{ note }} shortcode #19054

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Convert to {{ note }} shortcode #19054

merged 1 commit into from
Feb 10, 2020

Conversation

celestehorgan
Copy link
Contributor

Converts a "Note that.." phrasing to use the note shortcode.

This is also a test to see if editing a page via GitHub's markdown editor and not including a signoff in the description fails the CLA test or not, as I'm revising the instructions in the contribute section at the moment.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 10, 2020
@netlify
Copy link

netlify bot commented Feb 10, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3b7574e

https://deploy-preview-19054--kubernetes-io-master-staging.netlify.com

@zacharysarah
Copy link
Contributor

Nice and clean!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit eddbb00 into kubernetes:master Feb 10, 2020
@celestehorgan celestehorgan deleted the patch-1 branch February 10, 2020 19:07
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants