-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add styling for dl, dt, dd elements #19034
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 7942bd5 https://deploy-preview-19034--kubernetes-io-master-staging.netlify.com |
I'm overall fine with the idea of updating the styling here. The style guide recommends using italics when defining or introducing new terms so, with that in mind, how about making the text contents of @kbhawkey what do you think? If you want to ship this as-is, you can /unhold /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b5c9465
to
8da21a4
Compare
New changes are detected. LGTM label has been removed. |
@sftim, I am not sure if the italics work in this case. The block style seems to be closer to the list format and the style of the glossary. |
I think following the glossary example is fine here, but in that case I would bullet the terms if possible. (Will this impact #18968?) This is a much cleaner format--thanks for the improvement! ✨ |
@zacharysarah , The glossary is created from an unordered list and has some custom styling. |
8da21a4
to
7942bd5
Compare
Closing this issue, unless I hear that the docs need styling for definition lists 😃 . |
@kbhawkey: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Testing styling of definition lists.