Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update zh-trans content/zh/docs/reference/access-authn-authz/rbac.md #18947

Closed
wants to merge 6 commits into from
Closed

update zh-trans content/zh/docs/reference/access-authn-authz/rbac.md #18947

wants to merge 6 commits into from

Conversation

liyinda246
Copy link
Contributor

Add rbac.md file, I found that there is no corresponding Chinese translation in the official website, so I translated rbac.md in Chinese, I hope it will be helpful, thanks

@liyinda246
create rabc.md file
b6f8586 
Add rbac.md file,  I found that there is no corresponding Chinese translation in the official website, so I translated rbac.md in Chinese, I hope it will be helpful, thanks
新增rabc.md文件，我发现官网中没有对应的中文翻译，所以我将官网中对应的rbac文档翻译成中文，希望有帮助，谢谢
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 2, 2020
@netlify
Copy link

netlify bot commented Feb 2, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2aabb1f

https://deploy-preview-18947--kubernetes-io-master-staging.netlify.com

@liyinda246 liyinda246 changed the title create rabc.md file create rbac.md file Feb 2, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2020
@liyinda246
Copy link
Contributor Author

/assign @xichengliudui

@tanjunchen
Copy link
Member

tanjunchen commented Feb 2, 2020 •
edited
Loading

thanks your job
please see requirement
https://github.com/k8smeetup/k8s-official-translation

advice:fix title
update zh-trans content/zh/docs/reference/access-authn-authz/rbac.md

@tanjunchen
Copy link
Member

tanjunchen commented Feb 2, 2020 •
edited
Loading

/retitle update zh-trans content/zh/docs/reference/access-authn-authz/rbac.md

@liyinda246 liyinda246 changed the title create rbac.md file update zh-trans content/zh/docs/reference/access-authn-authz/rbac.md Feb 2, 2020
@liyinda246
Copy link
Contributor Author

/retitle update zh-trans content/zh/docs/reference/access-authn-authz/rbac.md
Thank you for your suggestion. I have changed the title

@markthink
Copy link

@liyinda246 原始英文补充一下，谢谢..

@liyinda246
Copy link
Contributor Author

@liyinda246 原始英文补充一下，谢谢..

original english url is https://kubernetes.io/docs/reference/access-authn-authz/rbac/

@tanjunchen
Copy link
Member

@liyinda246
see template #18880

@liyinda246
update rbac.md
de24c5c 
Add comments to the original English text
@liyinda246
Copy link
Contributor Author

@liyinda246 原始英文补充一下，谢谢..

Add comments to the original English text

@liyinda246
Copy link
Contributor Author

@liyinda246
see template #18880

thanks, Add comments to the original English text

@liyinda246
Copy link
Contributor Author

/retitle update zh-trans content/zh/docs/reference/access-authn-authz/rbac.md

This is my first time for PR, I add comments to the original English text，do you know if it meets the requirements now

@liyinda246
Copy link
Contributor Author

@liyinda246 原始英文补充一下，谢谢..

This is my first time for PR, I add comments to the original English text，do you know if it meets the requirements now

tengqm
tengqm reviewed Feb 4, 2020
View reviewed changes
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
@liyinda246 liyinda246 requested a review from tengqm February 4, 2020 13:56
@liyinda246
update rbac.md
d70b18d 
中英文之间应留白处未留白；
中文仍有半角标点出现；
有些句子不符合汉语表达习惯；
有些英文原文需要多读几遍，以求正确理解。
@liyinda246
Copy link
Contributor Author

@tengqm tengqm您好，我已经全文检查了您提到的上述问题，请您过目

@liyinda246 liyinda246 requested review from AdamDang and removed request for AdamDang February 5, 2020 07:28
@liyinda246 liyinda246 removed the request for review from xichengliudui February 12, 2020 08:42
@liyinda246
Copy link
Contributor Author

@tengqm 您好 1318行之前的内容已经提交啦，谢谢您的指导。

tengqm
tengqm reviewed Feb 12, 2020
View reviewed changes
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
@liyinda246
Copy link
Contributor Author

@tengqm 嗯 确实翻译的不够顺畅 我已经改过了 并且段落有切分的更小 请您再看一下 谢谢

tengqm
tengqm reviewed Feb 18, 2020
View reviewed changes
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
tengqm
tengqm reviewed Feb 19, 2020
View reviewed changes
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
tengqm
tengqm reviewed Feb 19, 2020
View reviewed changes
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
@liyinda246
Copy link
Contributor Author

@tengqm 刚才检查发现，之前的提交不是最新的（我应该将verb更改成“动作”但是上次的提交没有生效）导致您又重新帮我看了一遍，太不好意思了。我已经把review的内容更新了，您看这次提交应该成功了吧？

@tengqm
Copy link
Contributor

tengqm commented Feb 19, 2020

Pls squash your commits first.

tengqm
tengqm reviewed Feb 19, 2020
View reviewed changes
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 20, 2020
@liyinda246 liyinda246 force-pushed the master branch 2 times, most recently from c863e64 to d70b18d Compare February 21, 2020 02:44
@liyinda246
update rbac.md
d7c3e97 
review更新至代码行1940行
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 21, 2020
@liyinda246
Copy link
Contributor Author

@tengqm 已经合并多行commit，更新至1940行

tengqm
tengqm reviewed Feb 21, 2020
View reviewed changes
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
content/zh/docs/reference/access-authn-authz/rbac.md Outdated Show resolved Hide resolved
@liyinda246
update rbac.md
5b7941c
@liyinda246
update rbac.md
2aabb1f 
update zh-trans content/zh/docs/reference/access-authn-authz/rbac.md
tengqm
tengqm reviewed Feb 24, 2020
View reviewed changes
content/zh/docs/reference/access-authn-authz/rbac.md
@@ -2121,7 +2121,7 @@ kubectl create clusterrolebinding permissive-binding \
{{< warning >}}
下面的策略允许 **所有** 服务帐户充当集群管理员。
容器中运行的所有应用程序都会自动收到服务帐户的凭据，
可以对 API 执行任何操作，包括查看秘钥和修改权限，
可以对 API 执行任何操作，包括查看 Secrets 和修改权限。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the PR is in general not viewable, can you close this one and reopen a new one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the URL is not working due to too many review comments or sessions.
#18947

@liyinda246 liyinda246 closed this Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjunchen tanjunchen tanjunchen left review comments

@tengqm tengqm tengqm left review comments

Assignees

@tengqm tengqm

@xichengliudui xichengliudui

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liyinda246 @tanjunchen @markthink @k8s-ci-robot @tengqm @xichengliudui