Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce ambiguity on nodePort #18928

Merged
merged 2 commits into from
Feb 13, 2020
Merged

Reduce ambiguity on nodePort #18928

merged 2 commits into from
Feb 13, 2020

Conversation

maplain
Copy link

@maplain maplain commented Jan 31, 2020

At first sight, nodePort looks a lot like service.Spec.NodePort, though it just means a port allocated from "--service-node-port-range". Replacing "nodePort" with "node port" to add some clarity.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @maplain!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 31, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 31, 2020
@netlify
Copy link

netlify bot commented Jan 31, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 528cec3

https://deploy-preview-18928--kubernetes-io-master-staging.netlify.com

@maplain
Copy link
Author

maplain commented Feb 5, 2020

/assign @sftim

Fangyuan Li and others added 2 commits February 10, 2020 14:42
Reduce ambiguity on nodePort
c196466 
At first sight, nodePort looks a lot like service.Spec.NodePort, though it just means a port allocated from "--service-node-port-range". Replacing "nodePort" with "node port" to add some clarity.
@sftim
Update content/en/docs/tasks/access-application-cluster/create-extern…
528cec3 
…al-load-balancer.md

Co-Authored-By: Tim Bannister <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2020
sftim
sftim approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes the page better.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit b0aac61 into kubernetes:master Feb 13, 2020
@maplain maplain deleted the patch-1 branch February 18, 2020 21:19
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Feb 21, 2020
@sftim
Reduce ambiguity on nodePort (kubernetes#18928)
76b95eb 
* Reduce ambiguity on nodePort

At first sight, nodePort looks a lot like service.Spec.NodePort, though it just means a port allocated from "--service-node-port-range". Replacing "nodePort" with "node port" to add some clarity.

* Update content/en/docs/tasks/access-application-cluster/create-external-load-balancer.md

Co-Authored-By: Tim Bannister <[email protected]>

Co-authored-by: Tim Bannister <[email protected]>
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@sftim @wawa0210
Reduce ambiguity on nodePort (kubernetes#18928)
8873be0 
* Reduce ambiguity on nodePort

At first sight, nodePort looks a lot like service.Spec.NodePort, though it just means a port allocated from "--service-node-port-range". Replacing "nodePort" with "node port" to add some clarity.

* Update content/en/docs/tasks/access-application-cluster/create-external-load-balancer.md

Co-Authored-By: Tim Bannister <[email protected]>

Co-authored-by: Tim Bannister <[email protected]>
jiaj12 added a commit to jiaj12/website that referenced this pull request Jul 1, 2020
@jiaj12
Update create-external-load-balancer.md
7a50843 
update zh-trans to match (kubernetes#18928) modification
@jiaj12 jiaj12 mentioned this pull request Jul 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim approved these changes

@Bradamant3 Bradamant3 Awaiting requested review from Bradamant3

@steveperry-53 steveperry-53 Awaiting requested review from steveperry-53

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maplain @k8s-ci-robot @sftim