Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rbac redirect #18834

Merged
merged 1 commit into from
Feb 11, 2020
Merged

added rbac redirect #18834

merged 1 commit into from
Feb 11, 2020

Conversation

jimangel
Copy link
Member

Creates an alias for RBAC links: k8s.io/docs/rbac as tried and failed by @mauilion on TGIK.

I believe this shorter redirect is good for presentation slides and intersects with doc's security efforts.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 23, 2020
@netlify
Copy link

netlify bot commented Jan 23, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ee86d21

https://deploy-preview-18834--kubernetes-io-master-staging.netlify.com

static/_redirects Outdated Show resolved Hide resolved
@jimangel
Copy link
Member Author

/hold

Want to have a larger discussion before merging.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020
@zacharysarah
Copy link
Contributor

@jimangel Just checking--where are we on this PR?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2020
@jimangel
Copy link
Member Author

/hold cancel

Opened issue, amended PR, ready to merge if review is ok. Thanks!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2020
@zacharysarah
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2020
@zacharysarah
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit db5ddfa into kubernetes:master Feb 11, 2020
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Feb 21, 2020
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants