Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-trans: update pull request template to reflect the current workflow #18800

Closed
wants to merge 1 commit into from
Closed

zh-trans: update pull request template to reflect the current workflow #18800

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 21, 2020
@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f1850a5

https://deploy-preview-18800--kubernetes-io-master-staging.netlify.com

SataQiu
SataQiu reviewed Jan 21, 2020
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2020
markthink
markthink reviewed Jan 21, 2020
View reviewed changes
Copy link

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markthink
To complete the pull request process, please assign kbhawkey
You can assign the PR to them by writing /assign @kbhawkey in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sftim sftim mentioned this pull request Jan 21, 2020
Merged
@idealhack
Copy link
Member

/lgtm
/cc @jimangel

@k8s-ci-robot k8s-ci-robot requested a review from jimangel January 29, 2020 14:54
@jimangel
Copy link
Member

@chenrui333 please resolve conflicts if still necessary.

@k8s-ci-robot
Copy link
Contributor

@chenrui333: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2020
@jimangel
Copy link
Member

jimangel commented Apr 6, 2020

@chenrui333 this has been open with no action since Feb 10. Feel free to rebase or open a new PR. Thanks!

/close

@k8s-ci-robot
Copy link
Contributor

@jimangel: Closed this PR.

In response to this:

@chenrui333 this has been open with no action since Feb 10. Feel free to rebase or open a new PR. Thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu SataQiu left review comments

@markthink markthink markthink left review comments

@idealhack idealhack Awaiting requested review from idealhack

@xichengliudui xichengliudui Awaiting requested review from xichengliudui

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@idealhack idealhack

@markthink markthink

@SataQiu SataQiu

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chenrui333 @k8s-ci-robot @idealhack @jimangel @markthink @SataQiu