Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tą instalację -> tę instalację #18701

Closed
wants to merge 1 commit into from
Closed

tą instalację -> tę instalację #18701

wants to merge 1 commit into from

Conversation

wojtekidd
Copy link
Contributor

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 15, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @wojtekidd!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/pl Issues or PRs related to Polish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 15, 2020
@wojtekidd
Copy link
Contributor Author

I signed the CLA

@mfilocha mfilocha self-assigned this Jan 15, 2020
@mfilocha
Copy link
Contributor

/check-cla

@mfilocha
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2020
@sftim
Copy link
Contributor

sftim commented Jan 15, 2020

/check-cla

1 similar comment
@mfilocha
Copy link
Contributor

/check-cla

@mfilocha
Copy link
Contributor

@wojtekidd Are you sure the CLA is signed an your commit uses the same email like the one defined in GitHub?

@wojtekidd
Copy link
Contributor Author

I was changing emails lately, so probably that's the issue. Should I sign another CLA for the GitHub email or can I change the email in the already signed CLA to the one I use on GitHub?

@mfilocha
Copy link
Contributor

@wojtekidd From https://identity.linuxfoundation.org/projects/cncf:

  1. I signed the ICLA with the wrong email, what do I do?

Neither the email on the ICLA (captured from you Linux Foundation ID profile when you signed) nor the current email on the profile matters for passing the GitHub check.

For a PR to pass, each commit must pass this check: the Github user that the commit is attributed to (based on a match between the commit authorship and Github profile) must be linked to a Linux Foundation ID user (on the "social network logins" tab), who is authorized by a signed ICLA and/or a CCLA.

@wojtekidd
Copy link
Contributor Author

This is how it looks on my end

Screen Shot 2020-01-16 at 14 40 43

Copy link
Member

@nvtkaszpir nvtkaszpir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nvtkaszpir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2020
@nvtkaszpir
Copy link
Member

/check-cla

@mfilocha
Copy link
Contributor

/test

@mfilocha
Copy link
Contributor

@wojtekidd I'm afraid that check-cla command doesn't work as expected. Before we open an issue, could you ensure the e-mail address and name in your commit is exactly the same as is in your GitHub profile. I think it is the same, but please double check it.

@wojtekidd
Copy link
Contributor Author

My apologies - the commit was using my old work email. I've updated my email settings now, but please let me know if it would be more convenient for you guys to close this PR and I'll create a new one from scratch.

@mfilocha
Copy link
Contributor

@wojtekidd It should be enough to amend this commit with the proper email.

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2020
@mfilocha
Copy link
Contributor

/check-cla

@netlify
Copy link

netlify bot commented Jan 20, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f54032a

https://deploy-preview-18701--kubernetes-io-master-staging.netlify.com

@mfilocha
Copy link
Contributor

@wojtekidd I think you should squash all commits into one with the proper email. And push it with --force-with-lease

@wojtekidd
Copy link
Contributor Author

I think I've done so, but can't see any changes here :/

@mfilocha
Copy link
Contributor

No, there are three commits in this PR: https://github.com/kubernetes/website/pull/18701/commits

@mfilocha
Copy link
Contributor

@wojtekidd
Copy link
Contributor Author

I give up here, but thanks for the tip - I'll start once again from scratch according to the tutorial and I hope this time it will work. Sorry for all the problems caused :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/pl Issues or PRs related to Polish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants