Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en: Remove duplicate example #18637

Closed
wants to merge 1 commit into from

Conversation

merkata
Copy link
Contributor

@merkata merkata commented Jan 12, 2020

With #16974 and the removal of --include-uninitialized flag, the second
and third examples of kubectl delete become equal, thus leading to
duplication and being confusing. Suggest to remove the duplicate and
replace it with another example in the future if needed.

Observed in v1.16 and v1.17 documentation.

Signed-off-by: Mariyan Dimitrov [email protected]

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 12, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @merkata!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kbhawkey
You can assign the PR to them by writing /assign @kbhawkey in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 12, 2020
@merkata
Copy link
Contributor Author

merkata commented Jan 12, 2020

/assign @kbhawkey

@merkata
Copy link
Contributor Author

merkata commented Jan 12, 2020

/check-cla

@merkata
Copy link
Contributor Author

merkata commented Jan 12, 2020

I signed it

@merkata merkata force-pushed the bugfix/duplicate-examples branch from a9b493e to 4d92d7d Compare January 12, 2020 16:59
@merkata
Copy link
Contributor Author

merkata commented Jan 12, 2020

/check-cla

@php-coder
Copy link
Contributor

php-coder commented Jan 13, 2020

@merkata The signature might not get recognized because the e-mail in sign-off and author-s email don't match (mariyan.dimitrov+github@... vs mariyan.dimitrov@...).

@merkata
Copy link
Contributor Author

merkata commented Jan 13, 2020

@merkata The signature might not get recognized because the e-mail in sign-off and author-s email don't match (mariyan.dimitrov+github@... vs mariyan.dimitrov@...).

@php-coder yup, that is the case, I changed that, but I think I have one commit without the +github appended and one with, so the bot can't verify both commits :/
I've changed the e-mail with cncf to not include the +github and will re-run the check, here's hoping it works.

@merkata
Copy link
Contributor Author

merkata commented Jan 13, 2020

/check-cla

With kubernetes#16974 and the removal of --include-uninitialized flag, the second
and third examples of kubectl delete become equal, thus leading to
duplication and being confusing. Suggest to remove the duplicate and
replace it with another example in the future if needed.

Observed in v1.16 and v1.17 documentation.

Signed-off-by: Mariyan Dimitrov <[email protected]>
@merkata merkata force-pushed the bugfix/duplicate-examples branch from 4d92d7d to 26d7a04 Compare January 13, 2020 14:44
@merkata
Copy link
Contributor Author

merkata commented Jan 13, 2020

I've opened a new one #18656 so closing this PR, sorry for the mess...

@merkata merkata closed this Jan 13, 2020
@php-coder
Copy link
Contributor

Duplicate of #18656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants