Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Update the list of approvers/reviewers for English content #18500

Closed
wants to merge 141 commits into from
Closed

[WIP] Update the list of approvers/reviewers for English content #18500

wants to merge 141 commits into from

Conversation

zacharysarah
Copy link
Contributor

This PR:

  • Updates the list of current approvers and reviewers for English content
  • Restores @tengqm as an approver
  • Adds English approvers into the reviewers block to automate review assignment

Updating approvers/reviewers

Routine maintenance.

Restoring tengqm as an approver

SIG Docs chairs approached @tengqm privately to review recent actions in light of kubernetes/org#1468. Chairs agree that @tengqm understands the boundaries for write permissions in k/website. We're glad to welcome @tengqm back.

Adding approvers as reviewers

The PR wrangler role works to keep PR reviews and approvals moving, but it's not a substitute for regular review and participation by approvers. Adding approvers into the reviewers block will ensure that Prow regularly assigns PRs to approvers on a more equitable basis that doesn't overburden the PR wrangler for a given week.

/assign @jimangel @kbarnard10
/sig docs

woosanghun and others added 30 commits December 5, 2019 02:54
@woosanghun
Correct name of link to PersistentVolume (kubernetes#17589)
912afdb
@christophercarney
Add caution to behavior of --from-env-file (kubernetes#17585)
4806a82 
* Add caution to behavior of --from-env-file

* Reword warning to fix grammar
@nonylene
Fix invalid command (kubectl rolling-update) (kubernetes#17607)
99429b8 
`kubectl rolling-update` is the right command.

Doc: https://kubernetes.io/docs/tasks/run-application/rolling-update-replication-controller/
@tanjunchen
fix 404 urls in ko due to kubernetes#17668 (kubernetes#17709)
d05edd1
@tiendc
Adding vi document for create-cluster (kubernetes#17715)
c476cfb 
* Adding vi document for create-cluster

Signed-off-by: Dao Cong Tien <[email protected]>

* Update cluster-intro.html

* Update cluster-intro.html

* Update cluster-intro.html
Spanish Translation (kubernetes#14150)
bc680d3
@gochist @ysyukr
@novice81 @seokho-son
Fifth Korean l10n work for release-1.16 (kubernetes#17745)
f6e7bf6 
* Update files outdated Korean docs in dev-1.16-ko.5 (kubernetes#17537)
* Update Korean glossary (kubernetes#17619)
* Translate services-networking/endpoint-slices.md in Korean (kubernetes#17631)

Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Co-Authored-By: Wook-Jin, Lee <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
@butuzov
ja-docs: fixes for broken links. (kubernetes#17781)
9c1c84f 
1. Fixed markdown error that endup as 404 error at the URL
    https://kubernetes.io/ja/docs/reference/command-line-tools-reference/feature-gates/
    See - CSI(Container Storage Interface) link.

2. Minikube links at
    - content/ja/docs/tasks/tools/install-minikube.md
    - content/ja/includes/task-tutorial-prereqs.md

3. Link to CRI page at
   content/ja/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md

4. Windows Nodes link at

   https://kubernetes.io/ja/docs/setup/production-environment/windows/user-guide-windows-containers/
@PabloCastellano
Update repo url (kubernetes#17788)
ded6733 
service-catalog is not part of kubernetes-incubator anymore
@PabloCastellano
Use feature-state template (kubernetes#17787)
3c204c3 
* Use feature-state template

* Update certificate-rotation.md
rebase (kubernetes#15349)
6a36fde
@kihahu
Update kops Installation Steps (kubernetes#17726)
3640664 
* Document downloading the latest or a specific kops version

Add links to Install Homebrew On MacOS, Linux

* Update kops.md
@xieyanker
translate_networkpolicy (kubernetes#17733)
7293688 
Translate English sentences into Chinese
@MIBc
Add stateful set which hpa has supported (kubernetes#17806)
446e8e6 
As https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough/ and kubernetes#16425 say, the hpa has already supported stateful set.
@paulanunda
Removed duplicate link (kubernetes#17799)
0ce1f6c 
This change removes a duplicate link to the setup/best-practices/certificates page.
@bpelikan
Update kubectl get hpa output (kubernetes#17780)
824236c
@sharjeelaziz
Minor heading update according to the guideline (kubernetes#17747)
50176c6 
* Minor heading update according to the guideline

Fixed title of the document to use title case as described in the community guidelines.

* Capitalization fixes.
@novice81
Fixed the link (kubernetes#17731)
b3593f2
@tanalam2411 @sftim
Reference link added for Flex and CSI volume (kubernetes#17735)
7380475 
* Refernce link added for Flex and CSI volume

Added reference link of Flex and CSI volume under `Components of the CCM` section.

* Update content/en/docs/concepts/architecture/cloud-controller.md

Co-Authored-By: Tim Bannister <[email protected]>
@reung37
Update etcd.md (kubernetes#17751)
7012923
@reung37
Update 2019-04-04-local-persistent-volumes-ga.md (kubernetes#17753)
0498674
@ykhr53
add EKS cluster upgrading section (kubernetes#17800)
52f499f
@yue9944882
add blog: java controller framework (kubernetes#16135)
670937f
@sftim
Clean up configure-persistent-volume-storage task (kubernetes#16907)
5c27059
@praveen-kg
incorrect command for sort-by operation on pod (kubernetes#17032)
38546ab 
* incorrect command for sort-by

kubectl get pods -n test --sort-by=.spec.capacity.storage, is incorrect for pod as pods will not have capacity.storage under .spec, rather it should be for PersistentVolume.

So change the command  

kubectl get pv -n test --sort-by=.spec.capacity.storage

* Update cheatsheet.md
@j-zimnowoda
Update debug-application.md (kubernetes#17066)
1727afc 
A Service has targetPort to indicated Pod's containerPort (service.spec.ports.targetPort)
@sftim
Reword “Extend kubectl with plugins” (kubernetes#17005)
30c765d 
* Tweak kubectl plugins page

- drop text about kubectl plugin beta status etc
- fix output formatted as shell
- address the reader as “you”
- other tweaks

* Update links & details for Krew

* Update kubectl-plugins.md
@kihahu
fr-docs: Update kops Installation Steps (kubernetes#17805)
3b2728f
@tomplus
Add kubernetes-asyncio library (kubernetes#17812)
23dcbfe
How to upgrade minikube (kubernetes#17813)
c3844df
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2020
@zacharysarah
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@zacharysarah: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zacharysarah
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jan 6, 2020
@k8s-ci-robot
Copy link
Contributor

@zacharysarah: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zacharysarah zacharysarah changed the title Update the list of approvers/reviewers for English content [WIP] Update the list of approvers/reviewers for English content Jan 6, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jimangel
You can assign the PR to them by writing /assign @jimangel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 6, 2020
@zacharysarah
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@zacharysarah: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@jimangel jimangel

@kbarnard10 kbarnard10

Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.