Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve typo in dual-stack.md #18393

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Resolve typo in dual-stack.md #18393

merged 1 commit into from
Jan 8, 2020

Conversation

claudiajkang
Copy link
Contributor

I fixed IPV4 typo to IPv4 in docs/concepts/services-networking/dual-stack.md.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 1, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 1, 2020
@claudiajkang
Copy link
Contributor Author

/assign @Bradamant3

sftim
sftim reviewed Jan 1, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPv4 is the more common way of writing it.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 1, 2020
aramase
aramase reviewed Jan 2, 2020
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

bradtopol
bradtopol reviewed Jan 8, 2020
View reviewed changes
Copy link
Contributor

@bradtopol bradtopol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@bradtopol
Copy link
Contributor

/assign

@bradtopol
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit a013013 into kubernetes:master Jan 8, 2020
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Jan 13, 2020
@claudiajkang
Fix IPV4 typo to IPv4 (kubernetes#18393)
c054ab2
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@claudiajkang @wawa0210
Fix IPV4 typo to IPv4 (kubernetes#18393)
7312925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@aramase aramase aramase left review comments

@bradtopol bradtopol bradtopol left review comments

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@bradtopol bradtopol

@Bradamant3 Bradamant3

@aramase aramase

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@claudiajkang @bradtopol @k8s-ci-robot @aramase @sftim @Bradamant3