Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update /ja/docs/concepts/services-networking/service/ #18138
Update /ja/docs/concepts/services-networking/service/ #18138
Changes from 5 commits
d9a51cb
9ec2df8
39fedb7
1c1028c
96b4960
d40ce96
4c6eb34
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここのエンドポイントは Endpoints
またはEndpointSlice がエンドポイントスライスでもOK。
Endpoint Slice になってるから、カタカナの方がいいのかなという気もするけどどちらでも。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MasayaAoyama ここってのが具体的にどこか(たくさんありすぎて)よくわからないので、Suggestionでもらえると助かります 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Endpoints と EndpointSlice はリソース名です。(Deploymentと同じ)
Endpoints と Endpoint Slice は一般的な用語です。
判別がむずいので
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここって記載が紛らわしいですが、全てです。この部分だけじゃなくて。なのでsuggestionしてないです。
もしEndpointsをエンドポイントって訳すなら、Endpoint Slice はエンドポイントスライスです。逆でもいいので、どっちに合わせてもらってもいいと思います。
ページ全体・ページ外にも影響する話なので、それ以外も確認していただけると。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
原文は以下
Endpoints
、EndpointSlice
と大文字で明示的に書かれてるものはKubernetesリソースとして扱うことを考慮し、endpoint(s)やEndpoints Sliceとなっているものはリソースではないとみなして再度Pushしました