Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak linking for Kubernetes object concept #18122

Merged

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Dec 13, 2019

- Add a link from /docs/reference/using-api/api-concepts/
- Tweak other incoming links to match
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 13, 2019
@@ -12,9 +12,9 @@ This page explains how Kubernetes objects are represented in the Kubernetes API,
{{% /capture %}}

{{% capture body %}}
## Understanding Kubernetes Objects
## Understanding Kubernetes objects {#kubernetes-objects}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first heading anchor, so if any incoming links break, the reader experience isn't really affected.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 13, 2019
@bradtopol
Copy link
Contributor

Would like an extra pair of eyes on this one.
/assign @jimangel

@jimangel
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2faf102 into kubernetes:master Feb 11, 2020
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Feb 21, 2020
- Add a link from /docs/reference/using-api/api-concepts/
- Tweak other incoming links to match
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
- Add a link from /docs/reference/using-api/api-concepts/
- Tweak other incoming links to match
@sftim sftim deleted the 20191213_kubernetes_objects_hyperlinks branch June 9, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants