Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Promote VolumeSubpathEnvExpansion to GA (#16547)" #17946

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Revert "Promote VolumeSubpathEnvExpansion to GA (#16547)" #17946

merged 1 commit into from
Dec 6, 2019

Conversation

kbhawkey
Copy link
Contributor

@kbhawkey kbhawkey commented Dec 4, 2019 •
edited
Loading

Revert PR 16547 for 1.17 release.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 4, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit ea88902

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5de8420226e2c80007fe8562

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2019
@kbhawkey kbhawkey changed the title Revert "Promote VolumeSubpathEnvExpansion to GA (#16547)" [WIP]Revert "Promote VolumeSubpathEnvExpansion to GA (#16547)" Dec 4, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 4, 2019
@kbhawkey
Copy link
Contributor Author

kbhawkey commented Dec 5, 2019

Testing: see #17065

@daminisatya
Copy link
Contributor

@kbhawkey I think this is good to be merged.

/lgtm @jimangel @zacharysarah

@kbhawkey
Copy link
Contributor Author

kbhawkey commented Dec 5, 2019

@daminisatya , I tried this as a test. In theory, should work. Feel free to use this PR or create another for reverting the changes and then adding back the new content. Thanks.

@kbhawkey kbhawkey changed the title [WIP]Revert "Promote VolumeSubpathEnvExpansion to GA (#16547)" Revert "Promote VolumeSubpathEnvExpansion to GA (#16547)" Dec 5, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2019
@kbhawkey
Copy link
Contributor Author

kbhawkey commented Dec 5, 2019

I will close if not needed.
/assign @daminisatya

@zacharysarah
Copy link
Contributor

Here’s hoping!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6e99b11 into kubernetes:dev-1.17 Dec 6, 2019
@kbhawkey kbhawkey deleted the kb-1.17 branch December 12, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@zacharysarah zacharysarah

@daminisatya daminisatya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kbhawkey @k8sio-netlify-preview-bot @daminisatya @zacharysarah @k8s-ci-robot