Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en-docs: Add kubectl Installation Via Homebrew #17928

Merged

Conversation

kihahu
Copy link
Contributor

@kihahu kihahu commented Dec 3, 2019

  • Add kubectl Installation Via Homebrew

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 3, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 3, 2019
@netlify
Copy link

netlify bot commented Dec 3, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e4149c1

https://deploy-preview-17928--kubernetes-io-master-staging.netlify.com

@Rajakavitha1
Copy link
Contributor

looks good to me.
Checked https://docs.brew.sh/Homebrew-on-Linux . However, I don't have a Linux system to validate it.

@sftim could you please check this for technical accuracy and leave an lgtm.

@sftim
Copy link
Contributor

sftim commented Dec 4, 2019

I'll need to make a Linux sandbox with Homebrew in it, so it might be a while before I can get to this.

@kihahu
Copy link
Contributor Author

kihahu commented Dec 5, 2019

@Rajakavitha1 @sftim Would a screenshot from me of the command run help with the validation?

@Rajakavitha1
Copy link
Contributor

@Rajakavitha1 @sftim Would a screenshot from me of the command run help with the validation?

That would be awesome!! Thanks @kihahu

@kihahu
Copy link
Contributor Author

kihahu commented Dec 6, 2019

@Rajakavitha1 @sftim see below screenshots.

Installing brew on linux
linux-install-brew

Installing kubectl with brew install kubectl
install-kubectl

Installing kubectl with brew install kubernetes-cli
install-kubectl-2

@Rajakavitha1
Copy link
Contributor

Thank you so much for the screenshots @kihahu !!!
I have a suggestion for better content organisation: can we have a new title that reads: "Install using other package management" have the content for snap and homebrew in tabs similar to https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-using-native-package-management

@kihahu kihahu force-pushed the update-linux-kubectl-install branch from eade760 to e4149c1 Compare December 6, 2019 15:20
@kihahu
Copy link
Contributor Author

kihahu commented Dec 6, 2019

@Rajakavitha1 Take a look at the updated PR.

@Rajakavitha1
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 767f9fb into kubernetes:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants