Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify components requiring feature gate #17922

Merged
merged 2 commits into from
Dec 4, 2019
Merged

specify components requiring feature gate #17922

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abedfa4
specify components requiring feature gate
boluisa Dec 3, 2019
a8f869e
specify components requiring feature gate
boluisa Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/en/docs/concepts/workloads/controllers/ttlafterfinished.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ objects that have finished execution. TTL controller only handles
now, and may be expanded to handle other resources that will finish execution,
such as Pods and custom resources.

Alpha Disclaimer: this feature is currently alpha, and can be enabled with
Alpha Disclaimer: this feature is currently alpha, and can be enabled with both kube-controller-manager and kube-scheduler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting finding. In your commit message, you said "currently, TTLafterfinished feature gate is a flag that can be passed to kube-apiserver, kube-scheduler and kube-controller-manager." Here you only mention the last two. So you see how difficult it is to remember exactly which component accepts which gate ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, the required flag here should be kube-apiserver and kube-controller-manager.

[feature gate](/docs/reference/command-line-tools-reference/feature-gates/)
`TTLAfterFinished`.

Expand Down