Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate concepts/services-networking/ingress-controller in Korean #17858

Merged
merged 3 commits into from
Dec 2, 2019
Merged

Translate concepts/services-networking/ingress-controller in Korean #17858

merged 3 commits into from
Dec 2, 2019

Conversation

const-k
Copy link
Contributor

@const-k const-k commented Nov 28, 2019

from #17302

@const-k
Create ingress-controller.md
bfa2517 
Update ingress-controller.md
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2019
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 28, 2019
@netlify
Copy link

netlify bot commented Nov 28, 2019 •
edited
Loading

Deploy preview for k8s-dev-ko ready!

Built with commit 9b68436

https://deploy-preview-17858--k8s-dev-ko.netlify.com

@const-k
Copy link
Contributor Author

const-k commented Nov 29, 2019

/assign @gochist

gochist
gochist reviewed Dec 1, 2019
View reviewed changes
Copy link
Member

@gochist gochist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@const-k 감사합니다. 몇 가지 검토 의견 드립니다. 참고를 부탁드린 건은 선택적으로 반영 바랍니다.

content/ko/docs/concepts/services-networking/ingress-controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress-controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress-controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress-controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress-controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress-controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress-controller.md Outdated Show resolved Hide resolved
@gochist
Copy link
Member

gochist commented Dec 2, 2019

/hold
@const-k 파일 이름도 원본과 동일하게 변경 바랍니다. ingress-controllers의 's'가 누락되었습니다.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2019
@gochist
Copy link
Member

gochist commented Dec 2, 2019

@const-k 감사합니다!
/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 2, 2019
@gochist
Copy link
Member

gochist commented Dec 2, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit da62b58 into kubernetes:dev-1.16-ko.6 Dec 2, 2019
gochist pushed a commit that referenced this pull request Dec 6, 2019
@power8993 @const-k
@ysyukr @reung37 @Chihoon-Sung @claudiajkang @seokho-son @gochist
Sixth Korean l10n work for release-1.16
33719dc 
* Update _index.md (#17762)
* Update apparmor.md (#17767)
* Update hello-minikube.md (#17771)
* Update guestbook.md (#17773)
* Update localization_ko.md (#17777)
* Fix grammatical errors (#17776)
* Translate /docs/reference/issues-security/security.md in Korea (#17763)
* Create issues.md (#17765)
* Update basic-stateful-set.md (#17774)
* Fixed typo ko/docs/concepts/overview/components.md (#17778)
* Modify typo. (#17802)
* Update cloud-controller.md (#17760)
* Update file outdated korean docs in dev-1.16-ko.6. (#17772)
* Translate concepts/services-networking/ingress-controller in Korean (#17858)
* Update ingress-controller.md
* Translate services-networking/ingress.md in Korean. (#17807)
* Fix grammatical errors (#17775)
* Translate docs/contribute/style/write-new-topic.md in Korean (#17758)

Co-Authored-By: const-k <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: power8993 <[email protected]>
Co-Authored-By: reung37 <[email protected]>
Co-Authored-By: Chihoon-Sung <[email protected]>
Co-Authored-By: Claudia J.Kang <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
@gochist gochist mentioned this pull request Dec 6, 2019
Merged
k8s-ci-robot pushed a commit that referenced this pull request Dec 6, 2019
@gochist @const-k
@ysyukr @power8993 @reung37 @Chihoon-Sung @claudiajkang @seokho-son @k8s-ci-robot
Sixth Korean l10n work for release-1.16 (#17962)
cb559f1 
* Update _index.md (#17762)
* Update apparmor.md (#17767)
* Update hello-minikube.md (#17771)
* Update guestbook.md (#17773)
* Update localization_ko.md (#17777)
* Fix grammatical errors (#17776)
* Translate /docs/reference/issues-security/security.md in Korea (#17763)
* Create issues.md (#17765)
* Update basic-stateful-set.md (#17774)
* Fixed typo ko/docs/concepts/overview/components.md (#17778)
* Modify typo. (#17802)
* Update cloud-controller.md (#17760)
* Update file outdated korean docs in dev-1.16-ko.6. (#17772)
* Translate concepts/services-networking/ingress-controller in Korean (#17858)
* Update ingress-controller.md
* Translate services-networking/ingress.md in Korean. (#17807)
* Fix grammatical errors (#17775)
* Translate docs/contribute/style/write-new-topic.md in Korean (#17758)

Co-Authored-By: const-k <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: power8993 <[email protected]>
Co-Authored-By: reung37 <[email protected]>
Co-Authored-By: Chihoon-Sung <[email protected]>
Co-Authored-By: Claudia J.Kang <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gochist gochist gochist left review comments

@ianychoi ianychoi Awaiting requested review from ianychoi

Assignees

@gochist gochist

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@const-k @gochist @k8s-ci-robot