Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate docs/contribute/style/_index.md in Korea #17656 #17660

Closed
wants to merge 1 commit into from
Closed

Translate docs/contribute/style/_index.md in Korea #17656 #17660

wants to merge 1 commit into from

Conversation

reung37
Copy link
Contributor

@reung37 reung37 commented Nov 19, 2019

문서를 번역했습니다. 리뷰 부탁드리겠습니다.
from #17659
/language ko

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zacharysarah
You can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@reung37
Copy link
Contributor Author

reung37 commented Nov 19, 2019

/assign @zacharysarah
/assign @gochist
/assign @seokho-son

@netlify
Copy link

netlify bot commented Nov 19, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit 02c7c04

https://deploy-preview-17660--k8s-dev-ko.netlify.com

@gochist
Copy link
Member

gochist commented Nov 20, 2019

@reung37 The title and content do not match and it is duplicated with #17657 (title) and #17631 (content).

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2019
@gochist
Copy link
Member

gochist commented Nov 20, 2019

/triage duplicate

@k8s-ci-robot k8s-ci-robot added the triage/duplicate Indicates an issue is a duplicate of other open issue. label Nov 20, 2019
@seokho-son
Copy link
Member

/unassign @zacharysarah
/unassign @gochist

@seokho-son
Copy link
Member

@reung37 컨트리뷰션 감사합니다 :)
아쉽게도, 관련 문서에 대한 번역이 다른 PR에서 먼저 진행되고 있습니다. ( ISSUE #17520 , PR #17631 )
함께 공동으로 작업을 하다보니 부득이하게 중복 작업을 하게되는 경우가 가끔 발생합니다.
이 경우에는 Issue에 먼저 assign되신 분, 먼저 PR을 올리신 분의 PR을 우선적으로 선택하고 있습니다.

따라서, 향후에는 컨트리뷰터께서 작업 전에 관련된 키워드로 Issue (is:issue is:open language/ko 로 필터링 또는 문서의 키워드로 필터링)하셔서 관련 Issue가 이미 올라와 있는지, 누구에게 assign 되어 있는지 확인하시고 작업이 필요합니다.
아직 번역이 진행되지 않은 문서가 있고, 다른 분이 assign된 Issue나 PR이 없으면, 신규 Issue를 생성하셔서 self assign 후에 작업을 진행해주시면 됩니다. (물론 사소한 Bug fix의 경우에는 Issue 생성 없이 PR만 올려주셔도 무관합니다.)

해당 PR은 현 코멘트 확인하시고 Close를 해주시기 바랍니다.
작업하신 PR의 내용은 필요에 따라 PR #17631 에 리뷰 형식으로 의견 주시면 될 것 같습니다.

@reung37 reung37 closed this Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants