Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the expired link about sig-governance, for language es #17606

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Change the expired link about sig-governance, for language es #17606

merged 1 commit into from
Nov 18, 2019

Conversation

sivanzcw
Copy link
Contributor

  • link of sig-governace.md changed, change the link to the new address

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2019
@netlify
Copy link

netlify bot commented Nov 15, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e18a5be

https://deploy-preview-17606--kubernetes-io-master-staging.netlify.com

@sivanzcw
Copy link
Contributor Author

/cc @tengqm @xichengliudui

@sftim
Copy link
Contributor

sftim commented Nov 15, 2019

See my feedback on #17605

sftim
sftim reviewed Nov 15, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK, but should perhaps wait until the upstream localization (English) is amended.

@raelga
Copy link
Member

raelga commented Nov 15, 2019

Thank you @sivanzcw!

Let's wait for the upstream resolution as @Scrim suggests.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2019
@sivanzcw
Copy link
Contributor Author

The conversation in #17605 has been resolved, and I have modified the code to amend the issue, please review again. @raelga

@xichengliudui
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2019
@raelga
Copy link
Member

raelga commented Nov 18, 2019

Thank you very much @sivanzcw !

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga, xichengliudui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2019
@raelga
Copy link
Member

raelga commented Nov 18, 2019

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit ce299d5 into kubernetes:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@glo-pena glo-pena Awaiting requested review from glo-pena

@tengqm tengqm Awaiting requested review from tengqm

@xichengliudui xichengliudui Awaiting requested review from xichengliudui

Assignees

@raelga raelga

@xichengliudui xichengliudui

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sivanzcw @sftim @raelga @xichengliudui @k8s-ci-robot