Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop vestigial paragraph about kube-proxy feature compatibility #17483

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Drop vestigial paragraph about kube-proxy feature compatibility #17483

merged 1 commit into from
Nov 12, 2019

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Nov 8, 2019 •
edited
Loading

All supported Kubernetes versions offer all kube-proxy features previously listed, so the paragraph I'm removing isn't needed.

Preview

/kind cleanup

@sftim
Take kube-proxy features for granted
a3b4d5a 
All supported Kubernetes versions offer all kube-proxy features
previously listed.
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 8, 2019
@sftim
Copy link
Contributor Author

sftim commented Nov 8, 2019

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 8, 2019
@netlify
Copy link

netlify bot commented Nov 8, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a3b4d5a

https://deploy-preview-17483--kubernetes-io-master-staging.netlify.com

@sftim sftim changed the title Drop vestigial paragraph about kube-proxy feature compatability Drop vestigial paragraph about kube-proxy feature compatibility Nov 8, 2019
@tengqm
Copy link
Contributor

tengqm commented Nov 12, 2019

/lgtm
/approve
Nice.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit aa61310 into kubernetes:master Nov 12, 2019
neolit123 pushed a commit to neolit123/website that referenced this pull request Nov 14, 2019
@sftim @neolit123
Take kube-proxy features for granted (kubernetes#17483)
cb22a8b 
All supported Kubernetes versions offer all kube-proxy features
previously listed.
@sftim sftim deleted the 20191108_service_kube-proxy_version_compatability branch June 9, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bprashanth bprashanth Awaiting requested review from bprashanth

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sftim @tengqm @k8s-ci-robot